From owner-freebsd-testing@FreeBSD.ORG  Sun Feb 16 12:46:23 2014
Return-Path: <owner-freebsd-testing@FreeBSD.ORG>
Delivered-To: freebsd-testing@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 4E56AD9C;
 Sun, 16 Feb 2014 12:46:23 +0000 (UTC)
Received: from blu0-omc1-s16.blu0.hotmail.com (blu0-omc1-s16.blu0.hotmail.com
 [65.55.116.27]) by mx1.freebsd.org (Postfix) with ESMTP id 0C7401A41;
 Sun, 16 Feb 2014 12:46:22 +0000 (UTC)
Received: from BLU0-SMTP284 ([65.55.116.7]) by blu0-omc1-s16.blu0.hotmail.com
 with Microsoft SMTPSVC(6.0.3790.4675); 
 Sun, 16 Feb 2014 04:45:16 -0800
X-TMN: [SVW/0o0Py3Z/N41ptNkcT0XpYQbKUYfJ]
X-Originating-Email: [jmmv@outlook.com]
Message-ID: <BLU0-SMTP284F6428835416F4D9E3727C09E0@phx.gbl>
Received: from jmmv-macbookpro2.meroh.net ([108.176.158.82]) by
 BLU0-SMTP284.phx.gbl over TLS secured channel with Microsoft
 SMTPSVC(6.0.3790.4675); Sun, 16 Feb 2014 04:45:09 -0800
Content-Type: text/plain; charset="windows-1252"
MIME-Version: 1.0 (Mac OS X Mail 7.1 \(1827\))
Subject: Re: Compile error with gcc
From: Julio Merino <jmmv@outlook.com>
In-Reply-To: <D10C2EBB-36EC-4292-A944-4356EA5657F2@FreeBSD.org>
Date: Sun, 16 Feb 2014 07:45:11 -0500
Content-Transfer-Encoding: quoted-printable
References: <695E42A3-2009-4DD7-B10E-BF8465C89D39@gmail.com>
 <A8EF2DCC-5F11-4405-88D1-05A193AB7BAF@gmail.com>
 <D10C2EBB-36EC-4292-A944-4356EA5657F2@FreeBSD.org>
To: Dimitry Andric <dim@FreeBSD.org>
X-Mailer: Apple Mail (2.1827)
X-OriginalArrivalTime: 16 Feb 2014 12:45:15.0063 (UTC)
 FILETIME=[F075DC70:01CF2B14]
Cc: Garrett Cooper <yanegomi@gmail.com>, freebsd-testing@FreeBSD.org,
 David Chisnall <theraven@FreeBSD.org>
X-BeenThere: freebsd-testing@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Testing on FreeBSD <freebsd-testing.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-testing>, 
 <mailto:freebsd-testing-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-testing/>
List-Post: <mailto:freebsd-testing@freebsd.org>
List-Help: <mailto:freebsd-testing-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-testing>, 
 <mailto:freebsd-testing-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Feb 2014 12:46:23 -0000

On Feb 16, 2014, at 7:11, Dimitry Andric <dim@FreeBSD.org> wrote:
>=20
> I don't think this will always work correctly.  If MK_LIBCPLUSPLUS is
> defined in bsd.own.mk, it only means libc++ is being *built*, not that
> it is being used.
>=20
> It is probably easier and more fool-proof to check if _LIBCPP_VERSION =
is
> defined (which is the case when you use libc++) in bconfig.h, like so:
>=20
> Index: contrib/atf/bconfig.h
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- contrib/atf/bconfig.h       (revision 261974)
> +++ contrib/atf/bconfig.h       (working copy)
> @@ -56,7 +56,9 @@
> #define HAVE_UNSETENV 1
>=20
> /* Define to 1 if vsnprintf is in std */
> +#ifdef _LIBCPP_VERSION
> #define HAVE_VSNPRINTF_IN_STD 1
> +#endif

Let's not do that unless we can change configure.ac to generate these =
same contents.

Maybe we can just revert this to _not_ define HAVE_VSNPRINTF_IN_STD as =
it used to be the case before the new import?  Things were working just =
fine with both libstdc++ and libc++ even if that setting was not =
accurate for the latter...=