From owner-freebsd-current Sun Dec 15 14:47:53 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1754337B401 for ; Sun, 15 Dec 2002 14:47:52 -0800 (PST) Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id B88F343EC2 for ; Sun, 15 Dec 2002 14:47:51 -0800 (PST) (envelope-from dillon@apollo.backplane.com) Received: from apollo.backplane.com (localhost [127.0.0.1]) by apollo.backplane.com (8.12.5/8.12.5) with ESMTP id gBFMlpOM098706; Sun, 15 Dec 2002 14:47:51 -0800 (PST) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.12.5/8.12.5/Submit) id gBFMlp4d098705; Sun, 15 Dec 2002 14:47:51 -0800 (PST) (envelope-from dillon) Date: Sun, 15 Dec 2002 14:47:51 -0800 (PST) From: Matthew Dillon Message-Id: <200212152247.gBFMlp4d098705@apollo.backplane.com> To: Christian Brueffer Cc: current@FreeBSD.ORG Subject: Re: swapoff code comitted. References: <200212151946.gBFJktmo090730@apollo.backplane.com> <20021215223540.GA601@unixpages.org> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG : :How about renaming swapon(8) into swapctl(8) after this function enhancemen= :t? :This name reflects it's purpose much better and would be consistent with the :other BSDs. : :- Christian I think that's an excellent idea. We would have to do some rewriting to add the expected options but it would not be too difficult to do. Mainly just grunt work. e.g. the NetBSD swapctl command is this: swapctl -A [-p priority] [-t blk|noblk] -D dumpdev -U [-t blk|noblk] -a [-p priority] path -c -p priority path -d path -l | -s [-k] -z swapon -a | path And the OpenBSD swapctl command is this: swapctl -A [-p priority] [-t blk|noblk] swapctl -a [-p priority] path swapctl -c -p priority path swapctl -d path swapctl -l | -s [-k] swapon -a | path We would simply ignore priority since we don't support it, nor would we need a -t option since we do not have buffered block devices any more or a -c option since, again, we do not have priorities. I would keep 'swapoff' in anycase. It's an obvious command and like swapon could simply wind up being a hardlink to swapctl. I am not volunteering to do this, at least not right now. I have too big a stack of things that still need to be committed, but if someone else would like to tackle this I think it would be a nice little project for a developer with some free time to waste and I would be happy to review and test the work. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message