From owner-freebsd-testing@FreeBSD.ORG Mon Mar 3 18:22:46 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C5B83889; Mon, 3 Mar 2014 18:22:46 +0000 (UTC) Received: from mail-vc0-x22e.google.com (mail-vc0-x22e.google.com [IPv6:2607:f8b0:400c:c03::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 577499C8; Mon, 3 Mar 2014 18:22:46 +0000 (UTC) Received: by mail-vc0-f174.google.com with SMTP id im17so3961296vcb.33 for ; Mon, 03 Mar 2014 10:22:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=GwfS+NdjMBsLNFGJtBFvNbS9eZ6I4Fy3HtoBlaj2Hn4=; b=S4VLPez428NRYoTcR5zqnLu0kPPlaXYs/K2awqT/O8u6BLnFHUlkIrqmrDuSSJh0Jn MhsTU35rhFN4339kbnAJtarT0DbK1x+osXFzHsCAz0/F6o6KDkytg7+ZiEetzqurm+Bq 3PJW9uk9moiTNcOv5UZ1fc+qqb5DhWTvQYTPQlyan8pLdj+yDvDZoZ/str/zuAd+DJ3r 8Fgxsk+a+stLbqlutGmfcEU/bnypj/n3S8CAULp8x78nCxrMng/C7R6xLar791rs4iix vWv9f/piC7L8ZW5CCkKWzylBy9sDzZRji/Q7KUL8LxMxzDthcMeTsbUfvWHlT8TVSKJa sC7g== MIME-Version: 1.0 X-Received: by 10.221.34.211 with SMTP id st19mr18344966vcb.5.1393870965400; Mon, 03 Mar 2014 10:22:45 -0800 (PST) Received: by 10.221.67.136 with HTTP; Mon, 3 Mar 2014 10:22:45 -0800 (PST) In-Reply-To: References: <94D3F60A-1E12-418B-8313-E43C93878B95@gmail.com> <56D809A7-5387-475A-8C89-794E328F6935@gmail.com> Date: Mon, 3 Mar 2014 10:22:45 -0800 Message-ID: Subject: Re: [PATCH] Integrate pjdfstest into the build From: Garrett Cooper To: Julio Merino Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: "freebsd-testing@freebsd.org" , Pawel Jakub Dawidek X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Mar 2014 18:22:46 -0000 On Sun, Mar 2, 2014 at 3:00 PM, Julio Merino wrote: > On Sun, Mar 2, 2014 at 5:54 PM, Garrett Cooper wrote= : >>> * The test files should move from tools/regression/pjdfstest/ into the >>> new location under tests/sys/ and be renamed to follow the conventions >>> under src/test (e.g. xx.t -> xx_test). >> >> Please talk to Pawel about this. These tests have been developed and are= maintained (to some degree) outside FreeBSD: https://github.com/pjd/pjdfst= est . I'd rather treat this as an integration of the 3rd party package, not= a refactor. If you want me to install the tests like _test though, I'd be = more than happy to do that. > > Ah great; that's what I suspected given the mentions of other OSes in the= code! > > Then I believe this should really live under contrib/pjdfstest. Any > reason it's not there? If it's external, then yes, we should keep the > layout of the upstream sources without performing any renames (unless > Pawel wants to do them). I think it should be, but I don't own pjdfstest ;).. (largely for jmmv's benefit) Ultimately if pjd went this route, pjdfstest needs to be put in the vendor repo, reimported into FreeBSD under contrib, and then linked into the tree appropriately. Thank you :), -Garrett