From owner-cvs-all@FreeBSD.ORG  Fri Oct  3 02:24:51 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 985FF16A4B3; Fri,  3 Oct 2003 02:24:51 -0700 (PDT)
Received: from arginine.spc.org (arginine.spc.org [195.206.69.236])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2F7EC43FE5; Fri,  3 Oct 2003 02:24:47 -0700 (PDT)
	(envelope-from bms@spc.org)
Received: from localhost (localhost [127.0.0.1])
	by arginine.spc.org (Postfix) with ESMTP
	id 8CAAF65375; Fri,  3 Oct 2003 10:24:45 +0100 (BST)
Received: from arginine.spc.org ([127.0.0.1])
 by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id 92367-04-13; Fri,  3 Oct 2003 10:24:45 +0100 (BST)
Received: from saboteur.dek.spc.org (unknown [81.3.72.68])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by arginine.spc.org (Postfix) with ESMTP
	id 2ED236530D; Fri,  3 Oct 2003 10:24:45 +0100 (BST)
Received: by saboteur.dek.spc.org (Postfix, from userid 1001)
	id 2BE8831; Fri,  3 Oct 2003 10:24:40 +0100 (BST)
Date: Fri, 3 Oct 2003 10:24:40 +0100
From: Bruce M Simpson <bms@spc.org>
To: Bruce M Simpson <bms@FreeBSD.org>
Message-ID: <20031003092440.GE9213@saboteur.dek.spc.org>
Mail-Followup-To: Bruce M Simpson <bms@FreeBSD.org>,
	src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
References: <200310030919.h939JNP3049158@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200310030919.h939JNP3049158@repoman.freebsd.org>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/netinet if_ether.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Oct 2003 09:24:51 -0000

On Fri, Oct 03, 2003 at 02:19:23AM -0700, Bruce M Simpson wrote:
>   Only delete the route if arplookup() tried to create it. Do not delete
>   RTF_STATIC routes. Do not check for RTF_HOST so as to avoid being DoSed
>   when an RTF_GENMASK route exists in the table.
           ^^^^^^^^^^^^
I meant RTA_GENMASK (and thus RTF_CLONING) here of course.

This may not be the last of such commits -- it looks like our handling of
RTF_LLINFO may be inconsistent in a number of places, but this should be
enough to fix the denial-of-service.

BMS