From owner-freebsd-hackers@FreeBSD.ORG Wed Jun 11 08:42:53 2008 Return-Path: Delivered-To: freebsd-hackers@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3F768106564A for ; Wed, 11 Jun 2008 08:42:53 +0000 (UTC) (envelope-from sos@FreeBSD.ORG) Received: from deepcore.dk (adsl.deepcore.dk [87.63.29.106]) by mx1.freebsd.org (Postfix) with ESMTP id 6FE298FC1A for ; Wed, 11 Jun 2008 08:42:51 +0000 (UTC) (envelope-from sos@FreeBSD.ORG) Received: from laptop.deepcore.dk (laptop.deepcore.dk [192.168.0.138]) by deepcore.dk (8.14.2/8.13.8) with ESMTP id m5B8goD0048277; Wed, 11 Jun 2008 10:42:51 +0200 (CEST) (envelope-from sos@FreeBSD.ORG) Message-Id: From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= To: "Andrey V. Elsukov" In-Reply-To: <484F8609.3090601@yandex.ru> Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Apple Message framework v924) Date: Wed, 11 Jun 2008 10:42:50 +0200 References: <484F7EF9.5080602@yandex.ru> <5291278A-81B5-4665-B5FF-1A6B2EC9CD15@FreeBSD.ORG> <484F8609.3090601@yandex.ru> X-Mailer: Apple Mail (2.924) Cc: freebsd-hackers@FreeBSD.ORG Subject: Re: [RFC] patch to AHCI device detection code X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jun 2008 08:42:53 -0000 Hi You are right on that one of course, from my quick eyeballing the =20 patch I thought you enabled the reset sequence too, but on a closer =20 look its only the extra timeout, my bad. However, the most usual problem is that the devices does not leave a =20 signature behind due to the missing reset sequence. That problem is =20 50/50 as some controllers apparently doesn't like the resetting and =20 will leave busy set and a hanging channel. I'll be getting some new HW here in the lab tomorrow if all goes well, =20= that will let me play with this on one of the failing devices again. =20 Maybe I'll find a generic solution this time around. I'll commit this patch for now, as you said, it doesn't hurt.. -S=F8ren On 11Jun, 2008, at 10:00 , Andrey V. Elsukov wrote: > S=F8ren Schmidt wrote: >> Well, as you can see I tried this when I added the PM code to AHCI, =20= >> however one of the reasons I left it out again (for now) is that it =20= >> doesn't work on more than about 50% of the AHCI chipsets out there.. >> Modern HW in a nutshell, you win some you loose some ;) > > Hm.. I think it can't made regression. I don't see nothing dangerous > in addition 1s waiting (it doesn't enable softreset code, only PxTFD > reading loop).. > > --=20 > WBR, Andrey V. Elsukov >