From owner-freebsd-current@FreeBSD.ORG Mon Apr 9 01:07:19 2007 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 442DB16A402; Mon, 9 Apr 2007 01:07:19 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.freebsd.org (Postfix) with ESMTP id D7A5313C458; Mon, 9 Apr 2007 01:07:18 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id B2676487FB; Mon, 9 Apr 2007 03:07:16 +0200 (CEST) Received: from localhost (154.81.datacomsa.pl [195.34.81.154]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 1D4E5487F0; Mon, 9 Apr 2007 03:07:11 +0200 (CEST) Date: Mon, 9 Apr 2007 03:07:03 +0200 From: Pawel Jakub Dawidek To: Max Laier Message-ID: <20070409010703.GA74547@garage.freebsd.pl> References: <20070406025700.GB98545@garage.freebsd.pl> <86k5wo55s0.fsf@dwp.des.no> <200704081910.42852.max@love2party.net> <20070408185312.GY63916@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="82I3+IH0IqGh5yIs" Content-Disposition: inline In-Reply-To: <20070408185312.GY63916@garage.freebsd.pl> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r804 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00 autolearn=ham version=3.0.4 Cc: freebsd-fs@freebsd.org, Dag-Erling Sm?rgrav , freebsd-current@freebsd.org Subject: Re: ZFS committed to the FreeBSD base. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2007 01:07:19 -0000 --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 08, 2007 at 08:53:12PM +0200, Pawel Jakub Dawidek wrote: > fzap_upgrade() changes type from 'zap_micro' to 'zap_fat' and union is > used for this (see > sys/contrib/opensolaris/uts/common/fs/zfs/sys/zap_impl.h), that's why we > see this trash: >=20 > zap_num_entries_mtx =3D {lock_object =3D {lo_name =3D 0x70000
, > lo_type =3D 0x0, lo_flags =3D 2155822976, lo_witness_data =3D {lod_list = =3D {stqe_next =3D 0x0}, > lod_witness =3D 0x0}}, sx_lock =3D 1, sx_recurse =3D 0}, >=20 > I already use kmem_zalloc() (note _z_) for zap allocation in > zap_micro.c, so Max is right, that we have to clear this structure here. >=20 > I'm quite tired of tracking such problems, because our mechanism for > detecting already initialized locks is too simple (based on one bit), so > I'd prefer to improve it, or just add bzero() to mutex_init(). I just committed a fix. Now I do 13 bits check for already initialized locks detection instead of standard 1 bit check. Could you repeat your test? --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --82I3+IH0IqGh5yIs Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGGZG3ForvXbEpPzQRAkuzAJ9B0hzoFOn1hi/obdoxJDmh7vKZlwCg796x J97euQ4Nk4LEW9Qv1Z/mQsw= =qgao -----END PGP SIGNATURE----- --82I3+IH0IqGh5yIs--