From owner-cvs-all Mon Sep 4 9:38:16 2000 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 7ACBF37B423; Mon, 4 Sep 2000 09:38:11 -0700 (PDT) Received: (from ache@localhost) by nagual.pp.ru (8.11.0/8.11.0) id e84Gc7H53473; Mon, 4 Sep 2000 20:38:07 +0400 (MSD) (envelope-from ache) Date: Mon, 4 Sep 2000 20:38:06 +0400 From: "Andrey A. Chernov" To: Alexey Zelkin Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/nls msgcat.c Message-ID: <20000904203806.A53431@nagual.pp.ru> References: <200009041209.FAA22865@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200009041209.FAA22865@freefall.freebsd.org>; from phantom@FreeBSD.org on Mon, Sep 04, 2000 at 05:09:40AM -0700 Organization: Biomechanoid Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Mon, Sep 04, 2000 at 05:09:40AM -0700, Alexey Zelkin wrote: > * if empty string is passed to catopen() as name argument then > catopen() will set errno to ENOENT (File not found), not EINVAL > * move search code to LOOKUP() macro to shrink amount of duplicated code > * move common resource freeing actions to __nls_free_resources() function > * exclude from build code related to MCLoadAll defintion since it is not > using at all > * style(9) related whitespace changes If you remember, I object NOSPACE() macro, it should not overwrite errno passed from malloc with ENOMEM. Please fix. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message