From owner-freebsd-current  Tue Dec 19  7:36:16 2000
From owner-freebsd-current@FreeBSD.ORG  Tue Dec 19 07:36:13 2000
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from tasogare.imasy.or.jp (tasogare.imasy.or.jp [202.227.24.5])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5C88637B404; Tue, 19 Dec 2000 07:36:11 -0800 (PST)
Received: from localhost (iwasaki.imasy.or.jp [202.227.24.92])
	by tasogare.imasy.or.jp (8.11.1+3.4W/3.7W-tasogare/smtpfeed 1.07) with ESMTP id eBJFa6k74959;
	Wed, 20 Dec 2000 00:36:06 +0900 (JST)
	(envelope-from iwasaki@jp.FreeBSD.org)
To: roam@orbitel.bg
Cc: msmith@FreeBSD.org, current@FreeBSD.org
Subject: Re: dev/acpica/acpi.c - minor patch for cleaner poweroff
In-Reply-To: <20001218165732.A5418@ringworld.oblivion.bg>
References: <20001218165732.A5418@ringworld.oblivion.bg>
X-Mailer: Mew version 1.94.1 on Emacs 19.34 / Mule 2.3 (SUETSUMUHANA)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-Id: <20001220003605D.iwasaki@jp.FreeBSD.org>
Date: Wed, 20 Dec 2000 00:36:05 +0900
From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>
X-Dispatcher: imput version 20000228(IM140)
Lines: 43
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Hi,

> I think you're the main maintainer of the ACPICA codebase (and yes, I know
> that parts of it is imported from Intel).  Attached is a trivial patch which
> makes for cleaner testing for RB_POWEROFF in acpi_shutdown_final() - I've had
> various kernel/userland routines invoke reboot sequences where the howto had
> more bits set than RB_POWEROFF, e.g. RB_NOSYNC.  With this patch, shutdown -p
> works for me :)

Thanks, this patch looks good.  I'll fix this soon.
I'm sure mike will agree on it :-)

> Thanks for all the work on ACPICA :)
> 
> G'luck,
> Peter
> 
> PS. Please CC: me in replies as I'm not on -current.
> 
> -- 
> If I had finished this sentence,
> 
> Index: acpi.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/dev/acpica/acpi.c,v
> retrieving revision 1.7
> diff -u -r1.7 acpi.c
> --- acpi.c	2000/12/12 14:20:27	1.7
> +++ acpi.c	2000/12/18 14:55:43
> @@ -657,7 +657,7 @@
>  {
>      ACPI_STATUS	status;
>  
> -    if (howto == RB_POWEROFF) {
> +    if (howto & RB_POWEROFF) {
>  	printf("Power system off using ACPI...\n");
>  	if ((status = AcpiSetSystemSleepState(ACPI_STATE_S5)) != AE_OK) {
>  	    printf("ACPI power-off failed - %s\n", acpi_strerror(status));
> 
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-current" in the body of the message
> 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message