From owner-svn-ports-head@FreeBSD.ORG Tue May 21 20:16:50 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id CFEDE43A for ; Tue, 21 May 2013 20:16:50 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-pb0-x230.google.com (mail-pb0-x230.google.com [IPv6:2607:f8b0:400e:c01::230]) by mx1.freebsd.org (Postfix) with ESMTP id AA4EBB08 for ; Tue, 21 May 2013 20:16:50 +0000 (UTC) Received: by mail-pb0-f48.google.com with SMTP id md12so972969pbc.35 for ; Tue, 21 May 2013 13:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=CwTk6ls+m5hYYh11Pc4pslmbgqkgEsY9ki5qn/yFa7Q=; b=Bp+qzmpooF+CmILRpCBsCFvD/VTegg9Jb+ciM1ud9/IiPftRFyUL624wMARyV5Elhm XEzjgA5FB6C2zJUIJvkzAWYbcFf9p0/1kRVZNsqBEaLIV0+WJiKLIAd8i6nm5sgcXEez PWQ98vDf/qcX434NBioNmDcx1t4+1T8DIdaCg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=CwTk6ls+m5hYYh11Pc4pslmbgqkgEsY9ki5qn/yFa7Q=; b=IvxYLeR5SrT+tVvIMowRCK6Du2kOJBHqS6WKK2azAbGf3jQDOt1Hlb0+iDqx0+JyoP UR1+SSmOfi2lE1f8y1pX+3q4rZWOdEtfX2SGUPGlFcqOKJJkUuMl6/bmgC8sgExKqiRW ybD67y2w6IeeSOTiPoV83cDCKEy0spUH9px0lia3MMjvI1rfV9FEbEDiQ28reS1CHzyp TDJPvKObQD3+QxDU08k7VObX6q0gSH8fSHsfeNqYG5POQV/kJ7ipYOnMx8Gmp0RaIRxr iF8iTYsSyxpQXMseOxPFQ2FmisTgwfpqAf72n8sc/sYhvYF9mbXqcUsWa9DG9dXMSB6F pR9w== X-Received: by 10.66.154.72 with SMTP id vm8mr4918366pab.2.1369167410480; Tue, 21 May 2013 13:16:50 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.70.12.97 with HTTP; Tue, 21 May 2013 13:16:20 -0700 (PDT) In-Reply-To: <201305211629.r4LGTJn3060919@svn.freebsd.org> References: <201305211629.r4LGTJn3060919@svn.freebsd.org> From: Eitan Adler Date: Tue, 21 May 2013 22:16:20 +0200 X-Google-Sender-Auth: fe-aVI6WE27EdmlucIt-7D9ZYKs Message-ID: Subject: Re: svn commit: r318714 - in head/security/sudosh3: . files To: Mikhail Teterin Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQmMYBsfRCzpmGMDm6P8WkOpy9GECFOu56Rj2YCRevsSbiaPmD6i8a6vjKgxi4486EL1dlou Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 May 2013 20:16:50 -0000 On 21 May 2013 18:29, Mikhail Teterin wrote: > Author: mi > Date: Tue May 21 16:29:19 2013 > New Revision: 318714 > URL: http://svnweb.freebsd.org/changeset/ports/318714 > > Log: > Refactor the replay code to fix the reported vulnerability -- simply use mmap() > instead of a buffer. Is there a new version of this program upstream? > While here, fix warnings -- well enough for gcc48 to be happy with ``-Wall -W''. Changes like this are annoying because they make it harder to see what actually is required to be reported upstream. Is there a reason warnings can't be disabled? IMHO fixing "argument unused" errors in ports code is not very important. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams