From owner-freebsd-standards@FreeBSD.ORG Fri Feb 22 09:55:05 2013 Return-Path: Delivered-To: freebsd-standards@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 4EF366E7; Fri, 22 Feb 2013 09:55:05 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from theravensnest.org (theraven.freebsd.your.org [216.14.102.27]) by mx1.freebsd.org (Postfix) with ESMTP id 244C6288; Fri, 22 Feb 2013 09:55:04 +0000 (UTC) Received: from [192.168.0.2] (cpc10-cmbg15-2-0-cust123.5-4.cable.virginmedia.com [86.30.246.124]) (authenticated bits=0) by theravensnest.org (8.14.5/8.14.5) with ESMTP id r1M9ss8r062937 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Fri, 22 Feb 2013 09:54:57 GMT (envelope-from theraven@FreeBSD.org) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\)) Subject: Re: standards/175811: libstdc++ needs complex support in order use C99 From: David Chisnall In-Reply-To: <510F306A.6090009@missouri.edu> Date: Fri, 22 Feb 2013 09:54:48 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201302040328.r143SUd3039504@freefall.freebsd.org> <510F306A.6090009@missouri.edu> To: Stephen Montgomery-Smith X-Mailer: Apple Mail (2.1499) Cc: pfg@FreeBSD.org, freebsd-standards@FreeBSD.org, freebsd-numerics@FreeBSD.org X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Feb 2013 09:55:05 -0000 On 4 Feb 2013, at 03:52, Stephen Montgomery-Smith = wrote: > We do really seem to have a lot of working code right now. And the = main > barrier to commitment seems to be style issues. >=20 > For example, I have code at http://people.freebsd.org/~stephen/ for = the > complex arctrig functions. And Bruce has clog available. And > presumably he has logl and atanl also available. >=20 > The last I heard about my code is Bruce asking for some style changes. > However I really don't think I will have time to work on it until at > least the summer. And to be honest, style just isn't my thing. >=20 > I propose (a) that someone else takes over my code (and maybe Bruce's > code) and make the style changes, or (b) that we get a little less = fussy > about getting it all just so right and start committing stuff. >=20 > Let me add that the code we have is already far superior than anything > in Linux or NetBSD, who clearly didn't worry about huge numerical = errors > in many edge cases. Come on guys, let's start strutting our stuff. >=20 > Let's commit what we have, even if it isn't perfect. Yes, please can this happen? We are currently on 31 test failures in = the libc++ test suite on -HEAD, of which at least 18 are due to linker = failures trying to find missing libm functions. We are very close to = having a complete C++11 implementation, yet we are held up by the lack = of C99 support, and we are held up there by style nits? On behalf of core, please can we commit the existing code and worry = about the style later? Given the expertise required to work on the libm = functions, most of the people who are able to hack on the code have = already read it and so concerns about consistency readability are = somewhat misplaced. David