From owner-freebsd-current@FreeBSD.ORG Mon Dec 3 09:10:35 2007 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E16E616A41A; Mon, 3 Dec 2007 09:10:35 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id CF54213C45D; Mon, 3 Dec 2007 09:10:35 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 2013C46B88; Mon, 3 Dec 2007 04:15:13 -0500 (EST) Date: Mon, 3 Dec 2007 09:10:27 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Andrew Thompson In-Reply-To: <20071203032422.GC30756@heff.fud.org.nz> Message-ID: <20071203090800.U74097@fledge.watson.org> References: <20071202233435.G74097@fledge.watson.org> <20071203032422.GC30756@heff.fud.org.nz> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: hackers@FreeBSD.org, current@FreeBSD.org Subject: Re: procstat(1) committed to CVS HEAD X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Dec 2007 09:10:36 -0000 On Mon, 3 Dec 2007, Andrew Thompson wrote: > On Sun, Dec 02, 2007 at 11:38:45PM +0000, Robert Watson wrote: >> >> Dear all, (and FYI to hackers@ where I previousl sought feedback): >> >> I've now committed procstat(1) to CVS. I've found it to be quite a helpful >> debugging tool, am particularly pleased with -k/-kk, and would welcome >> feedback and ideas on further improving it. > > I would like to give some feedback. I listed the threads of proc 12 which is > intr, > > # procstat -t 12 > PID TID COMM CPU PRI STATE WCHAN > 12 100003 intr 0 40 wait - > 12 100004 intr 0 52 wait - > 12 100030 intr 0 16 wait - > [...] > 12 100036 intr 0 36 wait - > 12 100037 intr 0 24 wait - > > I had expected it to show the thread name such as 'irq14: ata0', is this > possible (and a good thing to do)? I just print out the 'comm' field returned by the generic sysctl, and I notice that top(1) with -S is now having the same problem as procstat(1). I think this is a kernel bug in how we initialize or otherwise handle thread names, and fairly recent, as it's not present on my 7.0BETA2 box. If I had to guess, it's that these are now 'true threads' under the single 'intr' proc, and that we're not exporting the thread name? > Great work on procstat :) Thanks! Robert N M Watson Computer Laboratory University of Cambridge