From owner-cvs-all@FreeBSD.ORG Fri Jan 30 07:26:13 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6E83716A4CE; Fri, 30 Jan 2004 07:26:13 -0800 (PST) Received: from mail.droso.net (koala.droso.net [193.162.142.74]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6338043D68; Fri, 30 Jan 2004 07:25:55 -0800 (PST) (envelope-from erwin@mail.droso.net) Received: by mail.droso.net (Postfix, from userid 1001) id 4DC442285F; Fri, 30 Jan 2004 16:25:53 +0100 (CET) Date: Fri, 30 Jan 2004 16:25:53 +0100 From: Erwin Lansing To: Doug Barton Message-ID: <20040130152553.GB46405@droso.net> References: <200401191544.i0JFib85052132@repoman.freebsd.org> <20040119163258.GB4722@dragon.nuxi.com> <359167705.1074533881@andromede.reaumur.absolight.net> <20040119184544.GB6433@dragon.nuxi.com> <2549890.1074541889@pouet.in.mat.cc> <20040119190410.GB72147@droso.net> <401A5DE3.8000902@dougbarton.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yNb1oOkm5a9FJOVX" Content-Disposition: inline In-Reply-To: <401A5DE3.8000902@dougbarton.net> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD/i386 5.2-RELEASE cc: cvs-ports@FreeBSD.org cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/mail/p5-Mail-SpamAssassin Makefile distinfo pkg-plist X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jan 2004 15:26:13 -0000 --yNb1oOkm5a9FJOVX Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 30, 2004 at 02:36:35PM +0100, Doug Barton wrote: > Erwin Lansing wrote: > >On Mon, Jan 19, 2004 at 07:51:29PM +0100, Mathieu Arnold wrote: > > > >>+-Le 19/01/2004 10:45 -0800, David O'Brien =E9crivait : > >>|=20 > >>| Well, I guess that opens up a discussion then. I don't use many "p5" > >>| ports, but I certainly do use SpamAssassin daily. So I hadn't noticed > >>| that they go against the Porters Handbook and 'portlint'. It is > >>| important to keep things all in the proper section so a user like me = can > >>| know what dependencies there are. Often I install dependencies from a > >>| precompiled package before I add local patches to the "leaf" port tha= t I > >>| ultimately want installed. > >> > >>Well, portlint will complain if you do things badly, but it won't compl= ain > >>when you do just that. > >>perl ports have been done this way for ages, I mean, the normal > >>dependencies at the right place, and the dependencies depending on perl > >>version at the end. I was told it was the right way to do it when I beg= an > >>updating ports, so I though it was the right way. > >> > > > >I'd say it's the only way, so unless someone finds a better way to make > >dependencies conditional, this is the right way. >=20 > Um, saying this is "the only way" is just plain silly. It worked just=20 > fine the way it was, so what we're talking about is style, not=20 > functionality. Let me rephrase. I don't know of any better way to do it. >=20 > What overwhelming problem is caused by including bsd.port.pre.mk early=20 > that needs to be solved by violating style guidelines followed by the=20 > rest of the ports tree? If you know a better way to make dependencies conditional on the perl version installed, I'd be happy to update my ports. >=20 > >make -V RUN_DEPENDS will give you the dependencies you want after > >evaluating the conditions. I would recommend using this instead of > >reading the raw Makefile. >=20 > Personally I find that 'make clean' does a pretty good job most of the ti= me. >=20 That would be another useful way. Cheers, -erwin --=20 _._ _,-'""`-._ Erwin Lansing (,-.`._,'( |\`-/| erwin@lansing.dk http://droso.org `-.-' \ )-`( , o o) erwin@FreeBSD.org -bf- `- \`_`"'- --yNb1oOkm5a9FJOVX Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAGneBqy9aWxUlaZARAhIbAKD5FGRoH7agLkHLtgN0OtEXUMlzlwCdH2xz D59VE81stX5kZYXPdJaA2Ik= =gVVY -----END PGP SIGNATURE----- --yNb1oOkm5a9FJOVX--