From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Oct 24 13:00:16 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5372310656B5 for ; Sat, 24 Oct 2009 13:00:16 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 04D508FC26 for ; Sat, 24 Oct 2009 13:00:16 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n9OD0EKv044666 for ; Sat, 24 Oct 2009 13:00:14 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n9OD0E7R044665; Sat, 24 Oct 2009 13:00:14 GMT (envelope-from gnats) Resent-Date: Sat, 24 Oct 2009 13:00:14 GMT Resent-Message-Id: <200910241300.n9OD0E7R044665@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Tijl Coosemans Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5A2E1106566B for ; Sat, 24 Oct 2009 12:50:20 +0000 (UTC) (envelope-from tijl@kalimero.kotnet.org) Received: from mailrelay002.isp.belgacom.be (mailrelay002.isp.belgacom.be [195.238.6.175]) by mx1.freebsd.org (Postfix) with ESMTP id ECEC08FC16 for ; Sat, 24 Oct 2009 12:50:19 +0000 (UTC) Received: from 242.44-245-81.adsl-dyn.isp.belgacom.be (HELO kalimero.kotnet.org) ([81.245.44.242]) by relay.skynet.be with ESMTP; 24 Oct 2009 14:50:18 +0200 Received: from kalimero.kotnet.org (kalimero.kotnet.org [127.0.0.1]) by kalimero.kotnet.org (8.14.3/8.14.3) with ESMTP id n9OCllEw064765 for ; Sat, 24 Oct 2009 14:47:47 +0200 (CEST) (envelope-from tijl@kalimero.kotnet.org) Received: (from tijl@localhost) by kalimero.kotnet.org (8.14.3/8.14.3/Submit) id n9OCllGp064764; Sat, 24 Oct 2009 14:47:47 +0200 (CEST) (envelope-from tijl) Message-Id: <200910241247.n9OCllGp064764@kalimero.kotnet.org> Date: Sat, 24 Oct 2009 14:47:47 +0200 (CEST) From: Tijl Coosemans To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/139884: audio/akode: fix dependency on libltdl X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Tijl Coosemans List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Oct 2009 13:00:16 -0000 >Number: 139884 >Category: ports >Synopsis: audio/akode: fix dependency on libltdl >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Oct 24 13:00:13 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Tijl Coosemans >Release: FreeBSD 7.2-STABLE i386 >Organization: >Environment: >Description: In the audio/akode Makefile the USE_AUTOTOOLS variable is assigned twice thereby erasing the dependency on libltdl. >How-To-Repeat: >Fix: The first patch fixes the USE_AUTOTOOLS assignment. The second patch is an attempt to simplify the Makefile and fix some portlint warnings. --- patch-akode begins here --- --- Makefile.orig 2009-10-24 13:07:24.000000000 +0200 +++ Makefile 2009-10-24 13:42:07.000000000 +0200 @@ -7,6 +7,7 @@ PORTNAME= akode PORTVERSION= 2.0.2 +PORTREVISION= 1 PORTEPOCH= 1 CATEGORIES= audio kde MASTER_SITES= ${MASTER_SITE_GENTOO} @@ -27,8 +28,7 @@ RESAMPLER "Resampler processing plugin" on \ XIPH "FLAC/Speex/Vorbis decoder plugin" on -USE_AUTOTOOLS= libltdl -USE_AUTOTOOLS= libtool:22 +USE_AUTOTOOLS= libtool:22 libltdl USE_BZIP2= yes USE_GMAKE= yes WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION} --- patch-akode ends here --- --- patch-akode2 begins here --- --- Makefile.orig 2009-10-24 13:43:00.000000000 +0200 +++ Makefile 2009-10-24 14:21:55.000000000 +0200 @@ -12,8 +12,7 @@ CATEGORIES= audio kde MASTER_SITES= ${MASTER_SITE_GENTOO} MASTER_SITE_SUBDIR=distfiles -DISTNAME= 30375-${PORTNAME}-${PORTVERSION}.tar.bz2 -EXTRACT_SUFX= # none +DISTFILES= 30375-${DISTNAME}${EXTRACT_SUFX} MAINTAINER= kde@FreeBSD.org COMMENT= Default KDE audio backend @@ -31,7 +30,6 @@ USE_AUTOTOOLS= libtool:22 libltdl USE_BZIP2= yes USE_GMAKE= yes -WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION} USE_LDCONFIG= yes PLIST_SUB+= MACHINE_ARCH=${MACHINE_ARCH} @@ -39,10 +37,10 @@ --with-extra-libs=${LOCALBASE}/lib \ --with-extra-includes=${LOCALBASE}/include -.include +.include .if defined(WITH_FFMPEG) -RUN_DEPENDS= ${LOCALBASE}/lib/libakode_ffmpeg_decoder.so:${PORTSDIR}/audio/akode-plugins-ffmpeg +RUN_DEPENDS+= ${LOCALBASE}/lib/libakode_ffmpeg_decoder.so:${PORTSDIR}/audio/akode-plugins-ffmpeg .endif .if defined(WITH_JACK) @@ -76,10 +74,4 @@ $$(all_libraries) ${PTHREAD_LIBS}|g' \ ${WRKSRC}/akode/akodeplay/Makefile.in -do-build: - cd ${WRKSRC}/akode && ${GMAKE} - -do-install: - cd ${WRKSRC}/akode && ${GMAKE} install - -.include +.include --- patch-akode2 ends here --- >Release-Note: >Audit-Trail: >Unformatted: