From owner-freebsd-net@FreeBSD.ORG  Fri Oct  2 01:40:03 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0905B106568B
	for <freebsd-net@hub.freebsd.org>; Fri,  2 Oct 2009 01:40:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id ED3348FC0C
	for <freebsd-net@hub.freebsd.org>; Fri,  2 Oct 2009 01:40:02 +0000 (UTC)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n921e2Tc039581
	for <freebsd-net@freefall.freebsd.org>; Fri, 2 Oct 2009 01:40:02 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n921e2mw039579;
	Fri, 2 Oct 2009 01:40:02 GMT (envelope-from gnats)
Date: Fri, 2 Oct 2009 01:40:02 GMT
Message-Id: <200910020140.n921e2mw039579@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/139113: commit references a PR
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Oct 2009 01:40:03 -0000

The following reply was made to PR kern/139113; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/139113: commit references a PR
Date: Fri,  2 Oct 2009 01:35:09 +0000 (UTC)

 Author: qingli
 Date: Fri Oct  2 01:34:55 2009
 New Revision: 197695
 URL: http://svn.freebsd.org/changeset/base/197695
 
 Log:
   Previously, if an address alias is configured on an interface, and
   this address alias has a prefix matching that of another address
   configured on the same interface, then the ARP entry for the alias
   is not deleted from the ARP table when that address alias is removed.
   This patch fixes the aforementioned issue.
   
   PR:		kern/139113
   MFC after:	3 days
 
 Modified:
   head/sys/netinet/in.c
 
 Modified: head/sys/netinet/in.c
 ==============================================================================
 --- head/sys/netinet/in.c	Fri Oct  2 01:07:28 2009	(r197694)
 +++ head/sys/netinet/in.c	Fri Oct  2 01:34:55 2009	(r197695)
 @@ -1060,6 +1060,8 @@ in_scrubprefix(struct in_ifaddr *target)
  	    !(target->ia_ifp->if_flags & IFF_LOOPBACK)) {
  		error = ifa_del_loopback_route((struct ifaddr *)target,
  				       (struct sockaddr *)&target->ia_addr);
 +		/* remove arp cache */
 +		arp_ifscrub(target->ia_ifp, IA_SIN(target)->sin_addr.s_addr);
  	}
  
  	if ((target->ia_flags & IFA_ROUTE) == 0) {
 @@ -1082,8 +1084,6 @@ in_scrubprefix(struct in_ifaddr *target)
  		prefix = target->ia_addr.sin_addr;
  		mask = target->ia_sockmask.sin_addr;
  		prefix.s_addr &= mask.s_addr;
 -		/* remove arp cache */
 -		arp_ifscrub(target->ia_ifp, IA_SIN(target)->sin_addr.s_addr);
  	}
  
  	IN_IFADDR_RLOCK();
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"