From owner-freebsd-current Mon Feb 4 19: 7: 4 2002 Delivered-To: freebsd-current@freebsd.org Received: from obsecurity.dyndns.org (adsl-64-165-226-47.dsl.lsan03.pacbell.net [64.165.226.47]) by hub.freebsd.org (Postfix) with ESMTP id E80B337B427; Mon, 4 Feb 2002 19:06:54 -0800 (PST) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 40A3266EF3; Mon, 4 Feb 2002 19:06:54 -0800 (PST) Date: Mon, 4 Feb 2002 19:06:54 -0800 From: Kris Kennaway To: David O'Brien Cc: Ruslan Ermilov , Mark Murray , current@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: pam_ssh world breakage (was: Re: cvs commit: src/lib/libpam Makefile.inc) Message-ID: <20020204190654.B36742@xor.obsecurity.org> References: <200202031551.g13Fpql76999@freefall.freebsd.org> <20020204153032.C58535@sunbay.com> <20020204091717.A16149@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="NMuMz9nt05w80d4+" Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20020204091717.A16149@dragon.nuxi.com>; from obrien@FreeBSD.org on Mon, Feb 04, 2002 at 09:17:17AM -0800 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --NMuMz9nt05w80d4+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 04, 2002 at 09:17:17AM -0800, David O'Brien wrote: > On Mon, Feb 04, 2002 at 03:30:32PM +0200, Ruslan Ermilov wrote: > > This delta breaks buildworld. gcc(1) has a known bug-feature > > of hiding some errors in standard system headers, making them > > invisible without -I. > ... > > and compile now can't survive the WARNS=3D4. >=20 > Not to mention there is ZERO way this code will pass WARNS=3D4 for GCC 3. > Please Committers, do not try to WARNS code right now -- there just is no > use. It will only get in the way later. If a new compiler generates more warnings then we should temporarily disable the warnings when the compiler is imported by setting WARNS=3D0 in . All of the Makefile.inc's which set a default WARNS value for a subdirectory use WARNS?=3D for this reason (so they can be globally overridden until someone goes through and fixes the new ones). If you use the argument that one shouldn't set WARNS because a new compiler will cause the tree to break, then there's no point having it at all since that condition will always be true. Kris --NMuMz9nt05w80d4+ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE8X0xNWry0BWjoQKURAlc8AKDGpW9H6S7aoQLIVX9bEFRSShoW+ACfeaBP RhZX3q1QY+ZmJ0BeOlak2HY= =sxPF -----END PGP SIGNATURE----- --NMuMz9nt05w80d4+-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message