From owner-freebsd-perl@FreeBSD.ORG  Thu Sep 25 20:31:03 2014
Return-Path: <owner-freebsd-perl@FreeBSD.ORG>
Delivered-To: perl@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id B654B550
 for <perl@FreeBSD.org>; Thu, 25 Sep 2014 20:31:03 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id A01FAC0B
 for <perl@FreeBSD.org>; Thu, 25 Sep 2014 20:31:03 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s8PKV3Dp044450
 for <perl@FreeBSD.org>; Thu, 25 Sep 2014 20:31:03 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: perl@FreeBSD.org
Subject: maintainer-approval requested: [Bug 193934] Mk/Uses/perl5.mk causes
 bogus "*** Error code 1 (ignored)" : [Attachment 147679] Fix bogus *** Error
 1 (ignored) and reinstate error check for ${FIND}/${SED}.
Date: Thu, 25 Sep 2014 20:31:03 +0000
X-Bugzilla-Type: request
Message-ID: <bug-193934-14331-ttq3QitYcC@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-193934-14331@https.bugs.freebsd.org/bugzilla/>
References: <bug-193934-14331@https.bugs.freebsd.org/bugzilla/>
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: freebsd-perl@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: maintainer of a number of perl-related ports
 <freebsd-perl.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-perl>,
 <mailto:freebsd-perl-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-perl/>
List-Post: <mailto:freebsd-perl@freebsd.org>
List-Help: <mailto:freebsd-perl-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-perl>,
 <mailto:freebsd-perl-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Sep 2014 20:31:03 -0000

Matthias Andree <mandree@FreeBSD.org> has asked perl@FreeBSD.org for
maintainer-approval:
Bug 193934: Mk/Uses/perl5.mk causes bogus "*** Error code 1 (ignored)"
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193934

Attachment 147679: Fix bogus *** Error 1 (ignored) and reinstate error check
for ${FIND}/${SED}.
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=147679&action=edit


------- Additional Comments from Matthias Andree <mandree@FreeBSD.org>
ports/Mk/Uses/perl5.mk abuses shell list sequencing with "&&" operators, and
this causes bogus errors in make on ports that run fix-packlist without the
SITE_PERL_REL/PERL_ARCH/auto dir installed, for instance, marino's upcoming
net-mgmt/netdisco port.

The syntax goes along these lines:

-@a && b

But if "a" failing isn't an error, then instead we should write:

if a ; then b ; fi

This will also ensure that errors from b are NOT ignored (they are now).

Proposed patch attached.  Please check if this needs an -exp run.