From owner-cvs-all@FreeBSD.ORG  Sun Jul 18 16:49:46 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9075616A4CE; Sun, 18 Jul 2004 16:49:46 +0000 (GMT)
Received: from ebb.errno.com (ebb.errno.com [66.127.85.87])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7296443D48; Sun, 18 Jul 2004 16:49:46 +0000 (GMT)
	(envelope-from sam@errno.com)
Received: from [66.127.85.91] ([66.127.85.91])
	(authenticated bits=0)
	by ebb.errno.com (8.12.9/8.12.6) with ESMTP id i6IGnkWi090554
	(version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO);
	Sun, 18 Jul 2004 09:49:46 -0700 (PDT)
	(envelope-from sam@errno.com)
From: Sam Leffler <sam@errno.com>
Organization: Errno Consulting
To: David Malone <dwmalone@FreeBSD.org>
Date: Sun, 18 Jul 2004 09:51:06 -0700
User-Agent: KMail/1.6.1
References: <200407180926.i6I9QYoB082932@repoman.freebsd.org>
In-Reply-To: <200407180926.i6I9QYoB082932@repoman.freebsd.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200407180951.06333.sam@errno.com>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/compat/linux linux_socket.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Jul 2004 16:49:46 -0000

On Sunday 18 July 2004 02:26 am, David Malone wrote:
> dwmalone    2004-07-18 09:26:34 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/compat/linux     linux_socket.c
>   Log:
>   I missed two pieces of the commit to this file. Robert has already
>   added one, this adds the other.

Not to pick on this commit, but recently there have been several commits where 
the log msg addressed _why_ the commit was done but never described _what_ 
was changed.  This is not helpful; someone coming along later with only CVS 
for reference must do a diff to even guess what the change does. Good commit 
msgs give a reader an understanding of the reason and content of a change.  

The above commit msg is more appropriate as followup mail to the actual commit 
(so it's not even included in CVS).

	Sam