From owner-svn-ports-head@freebsd.org Thu Oct 8 13:26:49 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BA9669B41D1; Thu, 8 Oct 2015 13:26:49 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x22f.google.com (mail-wi0-x22f.google.com [IPv6:2a00:1450:400c:c05::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5B3A41AA; Thu, 8 Oct 2015 13:26:49 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wicgb1 with SMTP id gb1so25657009wic.1; Thu, 08 Oct 2015 06:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=RIxmBmvFdybBVT/BUz8CO92hrh5rMNxOx1pt0sJgoGc=; b=zxs8AIpCRzRnorG2R2hXIwU6IvhVtMgCz0wRCZAh7b+qFCAIJ4C+ZOMCRqGpNdkVFc WSXTWETQIsEWtuWnGh7ki9+/lbKKEx3d0dxsypUvff4V8fy6hIXnayKdcqb+CW5EGchQ UDVOCcUkMWqH7bayRZiPEuCRuNU8m9DDVWQXoIH5x6eM2mkz6xMN0XwVmUU1yzcvdzGD 9gKwJVihHJXZBindUFFubnzbUgZ2kBYFjCVHX4mzhtHfRR1Lpr/Cb5vfpCzlvzrh3aag b4wPq4FtBIDrsGBWrrVHFhKtH16fOtcHFJnuYPabqhEpktPY8fK3TRArKc4YBX/0ybHu n3iA== X-Received: by 10.180.76.177 with SMTP id l17mr4223935wiw.16.1444310807863; Thu, 08 Oct 2015 06:26:47 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id bk4sm46110341wjc.1.2015.10.08.06.26.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Oct 2015 06:26:47 -0700 (PDT) Sender: Baptiste Daroussin Date: Thu, 8 Oct 2015 15:26:45 +0200 From: Baptiste Daroussin To: Dmitry Marakasov Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r398821 - head/security/maia Message-ID: <20151008132645.GJ91729@ivaldir.etoilebsd.net> References: <201510081319.t98DJg1g056186@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SLfjTIIQuAzj8yil" Content-Disposition: inline In-Reply-To: <201510081319.t98DJg1g056186@repo.freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2015 13:26:49 -0000 --SLfjTIIQuAzj8yil Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 08, 2015 at 01:19:42PM +0000, Dmitry Marakasov wrote: > Author: amdmi3 > Date: Thu Oct 8 13:19:42 2015 > New Revision: 398821 > URL: https://svnweb.freebsd.org/changeset/ports/398821 >=20 > Log: > - Move file owner handling to plist, fix stage as non-root > =20 > PR: 203287 > Submitted by: amdmi3 > Approved by: maintainer timeout (ek@purplehat.org, 2 weeks) >=20 > Modified: > head/security/maia/Makefile > head/security/maia/pkg-plist >=20 > Modified: head/security/maia/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/security/maia/Makefile Thu Oct 8 12:56:37 2015 (r398820) > +++ head/security/maia/Makefile Thu Oct 8 13:19:42 2015 (r398821) > @@ -338,7 +338,6 @@ post-patch: > do-install: > ${MKDIR} ${STAGEDIR}${WWWDIR} > @cd ${WRKSRC}/php && ${COPYTREE_SHARE} . ${STAGEDIR}${WWWDIR} > - ${CHOWN} -R ${WWWOWN}:${WWWGRP} ${STAGEDIR}${WWWDIR}/ > ${LN} -s ${PREFIX}/share/smarty ${STAGEDIR}${WWWDIR}/libs/Smarty > ${MKDIR} -p ${STAGEDIR}${DATADIR} > @cd ${WRKSRC}/scripts && ${COPYTREE_SHARE} . ${STAGEDIR}${DATADIR}/scri= pts > @@ -350,11 +349,10 @@ do-install: > ${INSTALL} -m 640 ${WRKSRC}/maiad.conf.dist ${STAGEDIR}${ETCDIR}/maiad.= conf.dist > ${INSTALL} -m 640 ${WRKSRC}/maia.conf.dist ${STAGEDIR}${ETCDIR}/maia.co= nf.dist > =20 > -.if ${PORT_OPTIONS:MDOCS} > +do-install-DOCS-on: > ${MKDIR} ${STAGEDIR}${DOCSDIR} > .for i in ${DOCS} > ${INSTALL_DATA} ${WRKSRC}/${i} ${STAGEDIR}${DOCSDIR} > .endfor > -.endif > =20 > .include >=20 > Modified: head/security/maia/pkg-plist > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/security/maia/pkg-plist Thu Oct 8 12:56:37 2015 (r398820) > +++ head/security/maia/pkg-plist Thu Oct 8 13:19:42 2015 (r398821) > @@ -40,6 +40,8 @@ sbin/maiad > %%DATADIR%%/scripts/send-quarantine-reminders.pl > %%DATADIR%%/scripts/stats-snapshot.pl > @mode > +@owner %%WWWOWN%% > +@group %%WWWGRP%% There is absolutly no reason those files belongs to those users only direct= ories (like cache directories) and files that the app expect to be able to modifi= ed when run should be own by such user, otherwise everything should belong to root/wheel: aka the default Best regards, Bapt --SLfjTIIQuAzj8yil Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlYWbxUACgkQ8kTtMUmk6Ey94wCbBZkSUKslGBuLNP3sFU+Tmh9D n2YAoLszMDJY8NeEKWTD34dH2vjAdVcI =fRHb -----END PGP SIGNATURE----- --SLfjTIIQuAzj8yil--