From owner-freebsd-bugs@FreeBSD.ORG Sun Sep 12 02:40:32 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1436E16A554 for ; Sun, 12 Sep 2004 02:40:32 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id DF65543D2F for ; Sun, 12 Sep 2004 02:40:31 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i8C2eVFn087179 for ; Sun, 12 Sep 2004 02:40:31 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8C2eV2c087178; Sun, 12 Sep 2004 02:40:31 GMT (envelope-from gnats) Resent-Date: Sun, 12 Sep 2004 02:40:31 GMT Resent-Message-Id: <200409120240.i8C2eV2c087178@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan Lukes Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A9C0C16A4CE for ; Sun, 12 Sep 2004 02:38:44 +0000 (GMT) Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243]) by mx1.FreeBSD.org (Postfix) with ESMTP id 883D543D41 for ; Sun, 12 Sep 2004 02:38:43 +0000 (GMT) (envelope-from dan@obluda.cz) Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1]) by kulesh.obluda.cz (8.13.1/8.13.1) with ESMTP id i8C2cfcY007123 for ; Sun, 12 Sep 2004 04:38:42 +0200 (CEST) (envelope-from dan@obluda.cz) Received: (from root@localhost) by kulesh.obluda.cz (8.13.1/8.13.1/Submit) id i8C2cfV6007122 for FreeBSD-gnats-submit@freebsd.org; Sun, 12 Sep 2004 04:38:41 +0200 (CEST) (envelope-from dan@obluda.cz) Message-Id: <200409120238.i8C2cfV6007122@kulesh.obluda.cz> Date: Sun, 12 Sep 2004 04:38:41 +0200 (CEST) From: Dan Lukes To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/71631: [PATCH] cleanup of the usr.sbin/pppctl code X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Dan Lukes List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Sep 2004 02:40:32 -0000 >Number: 71631 >Category: bin >Synopsis: [PATCH] cleanup of the usr.sbin/pppctl code >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Sep 12 02:40:30 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Dan Lukes >Release: FreeBSD 5.3-BETA3 i386 >Organization: Obludarium >Environment: System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan@kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386 usr.sbin/pppctl/pppctl.c,v 1.32 2003/12/07 08:39:29 tjr >Description: There are more than 5000 warnings issued during "make buildworld". Some of them are false positives, but some of them are sign of true errors. Nobody is upset by warnings due it's amount, so some errors remain uncorrected. I want to cleanup the code-base from warnings, so warnings will become "attention mark" again. usr.sbin/pppctl/pppctl.c:368: warning: 'fd' might be used uninitialized in this function 'fd' is initialized with no exception, so turn-off warning only >How-To-Repeat: N/A >Fix: *** usr.sbin/pppctl/pppctl.c.ORIG Sun Dec 7 23:02:31 2003 --- usr.sbin/pppctl/pppctl.c Sat Sep 11 13:42:01 2004 *************** *** 365,371 **** main(int argc, char **argv) { struct sockaddr_un ifsun; ! int n, arg, fd, len, verbose, save_errno, hide1, hide1off, hide2; unsigned TimeoutVal; char *DoneWord = "x", *next, *start; struct sigaction act, oact; --- 365,372 ---- main(int argc, char **argv) { struct sockaddr_un ifsun; ! int n, arg, len, verbose, save_errno, hide1, hide1off, hide2; ! int fd = fd; /* init to avoid "might be used unitialized" warning 8/ unsigned TimeoutVal; char *DoneWord = "x", *next, *start; struct sigaction act, oact; >Release-Note: >Audit-Trail: >Unformatted: