From owner-cvs-all Sun Mar 11 15:28:50 2001 Delivered-To: cvs-all@freebsd.org Received: from moby.geekhouse.net (moby.geekhouse.net [64.81.6.36]) by hub.freebsd.org (Postfix) with ESMTP id A2B9237B71B; Sun, 11 Mar 2001 15:28:40 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: from laptop.baldwin.cx (john@dhcp152.geekhouse.net [192.168.1.152]) by moby.geekhouse.net (8.11.0/8.9.3) with ESMTP id f2BNUB157499; Sun, 11 Mar 2001 15:30:11 -0800 (PST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Sun, 11 Mar 2001 15:28:13 -0800 (PST) From: John Baldwin To: Dag-Erling Smorgrav Subject: Re: cvs commit: src/sys/alpha/linux linux_machdep.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 11-Mar-01 Dag-Erling Smorgrav wrote: > John Baldwin writes: >> Log: >> Create clone'd linux processes as stopped processes at first and don't >> actually make them runnable until after the emulator layer has had a >> chance >> to perform fixups. > > This commit is wrong: rfork() masks away RFSTOPPED, so fork1() queues > the process, then linux_clone() queues it once again. This would have > gotten caught if runq_add() asserted that it didn't get passed an > already-queued process. Is RFSTOPPED in RFKERNELONLY then? I thought only RFHIGHPID was in RFKERNELONLY. *sigh* Well, looks like I need to hack up rfork somehow, because this commit is correct, but the linux compatibility layer needs a way to bypass the userland checks that rfork provides. Possibly a rfork1(). > The corresponding commit to src/sys/alpha/linux/linux_machdep.c is of > course also incorrect. > > DES > -- > Dag-Erling Smorgrav - des@ofug.org -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message