From owner-freebsd-ports-bugs@FreeBSD.ORG  Mon Apr 14 23:10:00 2014
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id AA27FBC4
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Mon, 14 Apr 2014 23:10:00 +0000 (UTC)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 857631899
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Mon, 14 Apr 2014 23:10:00 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s3ENA0IV064203
 for <freebsd-ports-bugs@freefall.freebsd.org>; Mon, 14 Apr 2014 23:10:00 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s3ENA0U0064202;
 Mon, 14 Apr 2014 23:10:00 GMT (envelope-from gnats)
Resent-Date: Mon, 14 Apr 2014 23:10:00 GMT
Resent-Message-Id: <201404142310.s3ENA0U0064202@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, JMV <banshee@abattoir.com>
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 25F88AC0
 for <FreeBSD-gnats-submit@freebsd.org>; Mon, 14 Apr 2014 23:00:40 +0000 (UTC)
Received: from gabriella.abattoir.com (70-36-157-19.static.sonic.net
 [70.36.157.19])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 02ABD1848
 for <FreeBSD-gnats-submit@freebsd.org>; Mon, 14 Apr 2014 23:00:39 +0000 (UTC)
Received: from gabriella.abattoir.com (localhost [127.0.0.1])
 by gabriella.abattoir.com (8.14.7/8.14.7) with ESMTP id s3EMnbaT017182
 for <FreeBSD-gnats-submit@freebsd.org>; Mon, 14 Apr 2014 15:49:37 -0700 (PDT)
 (envelope-from banshee@gabriella.abattoir.com)
Received: (from root@localhost)
 by gabriella.abattoir.com (8.14.7/8.14.7/Submit) id s3EMnbxI017181;
 Mon, 14 Apr 2014 15:49:37 -0700 (PDT) (envelope-from banshee)
Message-Id: <201404142249.s3EMnbxI017181@gabriella.abattoir.com>
Date: Mon, 14 Apr 2014 15:49:37 -0700 (PDT)
From: JMV <banshee@abattoir.com>
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.114
Subject: ports/188635: port security/sshguard doesn't start without explicit
 pidfile
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: JMV <banshee@abattoir.com>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Apr 2014 23:10:00 -0000


>Number:         188635
>Category:       ports
>Synopsis:       port security/sshguard doesn't start without explicit pidfile
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 14 23:10:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     JMV
>Release:        FreeBSD 9.2-RELEASE-p4 amd64
>Organization:
just-another-unix-hacker
>Environment:
System: FreeBSD gabriella.abattoir.com 9.2-RELEASE-p4 FreeBSD 9.2-RELEASE-p4 #0: Tue Apr 8 18:08:22 UTC 2014 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
	/usr/local/etc/rc.d/sshguard silently fails to start if sshguard_pidfile is not defined in /etc/rc.conf because the start script refers to the wrong variable.

>How-To-Repeat:
	Install security/sshguard
	Ensure rc.conf contains sshguard_enable="YES"
	Ensure rc.conf does not contain sshguard_pidfile
	$ service sshguard start
	Silently fails to start.
>Fix:
command_args="-cf ${actual_command} -b ${sshguard_blacklist} ${sshguard_watch_params} -a ${sshguard_safety_thresh} -p ${sshguard_pardon_min_interval} -s ${sshguard_prescribe_interval} -w ${sshguard_whitelistfile} -i ${sshguard_pidfile}"

should be

command_args="-cf ${actual_command} -b ${sshguard_blacklist} ${sshguard_watch_params} -a ${sshguard_safety_thresh} -p ${sshguard_pardon_min_interval} -s ${sshguard_prescribe_interval} -w ${sshguard_whitelistfile} -i ${pidfile}"

>Release-Note:
>Audit-Trail:
>Unformatted: