From owner-svn-src-all@FreeBSD.ORG  Mon Oct 24 14:29:08 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8F83A1065673;
	Mon, 24 Oct 2011 14:29:08 +0000 (UTC)
	(envelope-from rdivacky@vlakno.cz)
Received: from vlakno.cz (lev.vlakno.cz [46.28.110.116])
	by mx1.freebsd.org (Postfix) with ESMTP id 5146D8FC16;
	Mon, 24 Oct 2011 14:29:08 +0000 (UTC)
Received: by vlakno.cz (Postfix, from userid 1002)
	id 864027F384F; Mon, 24 Oct 2011 16:22:45 +0200 (CEST)
Date: Mon, 24 Oct 2011 16:22:45 +0200
From: Roman Divacky <rdivacky@freebsd.org>
To: Konstantin Belousov <kib@FreeBSD.org>
Message-ID: <20111024142245.GA73120@freebsd.org>
References: <201110241353.p9ODrW99046445@svn.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201110241353.p9ODrW99046445@svn.freebsd.org>
User-Agent: Mutt/1.4.2.3i
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r226687 - head/sys/fs/nullfs
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Oct 2011 14:29:08 -0000

On Mon, Oct 24, 2011 at 01:53:32PM +0000, Konstantin Belousov wrote:
> Author: kib
> Date: Mon Oct 24 13:53:32 2011
> New Revision: 226687
> URL: http://svn.freebsd.org/changeset/base/226687
> 
> Log:
>   The only possible error return from null_nodeget() is due to insmntque1
>   failure (the getnewvnode cannot return an error). In this case, the
>   null_insmntque_dtr() already unlocked the reclaimed vnode, so VOP_UNLOCK()
>   in the nullfs_mount() after null_nodeget() failure is wrong.
>   
>   Tested by:	pho
>   MFC after:	1 week
> 
> Modified:
>   head/sys/fs/nullfs/null_vfsops.c
> 
> Modified: head/sys/fs/nullfs/null_vfsops.c
> ==============================================================================
> --- head/sys/fs/nullfs/null_vfsops.c	Mon Oct 24 13:48:13 2011	(r226686)
> +++ head/sys/fs/nullfs/null_vfsops.c	Mon Oct 24 13:53:32 2011	(r226687)
> @@ -157,7 +157,6 @@ nullfs_mount(struct mount *mp)
>  	 * Make sure the node alias worked
>  	 */
>  	if (error) {
> -		VOP_UNLOCK(vp, 0);

Maybe you want to assert that it's indeed unlocked at this point?

roman