From owner-svn-src-all@FreeBSD.ORG Thu May 24 06:37:33 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 60300106564A; Thu, 24 May 2012 06:37:33 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail17.syd.optusnet.com.au (mail17.syd.optusnet.com.au [211.29.132.198]) by mx1.freebsd.org (Postfix) with ESMTP id D18008FC18; Thu, 24 May 2012 06:37:32 +0000 (UTC) Received: from c122-106-171-232.carlnfd1.nsw.optusnet.com.au (c122-106-171-232.carlnfd1.nsw.optusnet.com.au [122.106.171.232]) by mail17.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id q4O6bNkM019413 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 24 May 2012 16:37:24 +1000 Date: Thu, 24 May 2012 16:37:23 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: "David O'Brien" In-Reply-To: <20120523234154.GA22380@dragon.NUXI.org> Message-ID: <20120524163545.T1094@besplex.bde.org> References: <201205221818.q4MII7lk019626@svn.freebsd.org> <4FBCCED9.9050308@FreeBSD.org> <20120523234154.GA22380@dragon.NUXI.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Dimitry Andric Subject: Re: svn commit: r235797 - head/contrib/gcc X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2012 06:37:33 -0000 On Wed, 23 May 2012, David O'Brien wrote: > On Wed, May 23, 2012 at 01:49:45PM +0200, Dimitry Andric wrote: >> On 2012-05-22 20:18, David E. O'Brien wrote: >>> Log: >>> Do not incorrectly warn when printing a quad_t using "%qd" on 64-bit platforms. > ... >> Until all the additional warnings this causes have been fixed, can this >> commit please be reverted for now? > > Yes. I cannot believe we've been abusing "%q" this badly. Using it at all is using it badly, so your change should have had no effect. But when it was used to print quad_t's, its use was almost reasonable, and the change broke that too. Bruce