From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Apr 15 19:20:00 2014 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9FBC66E3 for ; Tue, 15 Apr 2014 19:20:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7B2271252 for ; Tue, 15 Apr 2014 19:20:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s3FJK0Cq081434 for ; Tue, 15 Apr 2014 19:20:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s3FJK08b081433; Tue, 15 Apr 2014 19:20:00 GMT (envelope-from gnats) Resent-Date: Tue, 15 Apr 2014 19:20:00 GMT Resent-Message-Id: <201404151920.s3FJK08b081433@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, John Hein Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 07A5767A; Tue, 15 Apr 2014 19:17:57 +0000 (UTC) Received: from duck.symmetricom.us (duck.symmetricom.us [206.168.13.214]) by mx1.freebsd.org (Postfix) with ESMTP id B4840123D; Tue, 15 Apr 2014 19:17:56 +0000 (UTC) Received: from gromit.timing.com (gromit.timing.com [206.168.13.209]) by duck.symmetricom.us (8.14.6/8.14.6) with ESMTP id s3FJHmvv029838; Tue, 15 Apr 2014 13:17:48 -0600 (MDT) (envelope-from jhein@symmetricom.com) Received: from gromit.timing.com (localhost [127.0.0.1]) by gromit.timing.com (8.14.7/8.14.5) with ESMTP id s3FJHmHl028411; Tue, 15 Apr 2014 13:17:48 -0600 (MDT) (envelope-from jhein@gromit.timing.com) Received: (from jhein@localhost) by gromit.timing.com (8.14.7/8.14.7/Submit) id s3FJHmYF028410; Tue, 15 Apr 2014 13:17:48 -0600 (MDT) (envelope-from jhein) Message-Id: <201404151917.s3FJHmYF028410@gromit.timing.com> Date: Tue, 15 Apr 2014 13:17:48 -0600 (MDT) From: John Hein To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.114 Subject: ports/188670: [patch] update devel/seed (2.31.91) to build with both new and older readline Cc: gnome@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: John Hein List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Apr 2014 19:20:00 -0000 >Number: 188670 >Category: ports >Synopsis: [patch] update devel/seed (2.31.91) to build with both new and older readline >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Apr 15 19:20:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: John Hein >Release: >Organization: >Environment: System: >Description: If the devel/readline (6.3+) port is installed, you can get build errors with devel/seed (currently 2.31.91_4). gmake[3]: Entering directory `/d/pub/jhein/.no-amanda-backup/wd/usr/ports/devel/seed/work/seed-2.31.91/modules/readline' CC libseed_readline_la-seed-readline.lo seed-readline.c: In function 'seed_readline_bind': seed-readline.c:80: error: 'Function' undeclared (first use in this function) seed-readline.c:80: error: (Each undeclared identifier is reported only once seed-readline.c:80: error: for each function it appears in.) seed-readline.c:80: error: expected expression before ')' token >How-To-Repeat: install devel/readline (6.3.3) try to build devel/seed (2.31.91_4) >Fix: Index: devel/seed/files/patch-modules_readline_seed-readline.c =================================================================== --- devel/seed/files/patch-modules_readline_seed-readline.c (revision 0) +++ devel/seed/files/patch-modules_readline_seed-readline.c (working copy) @@ -0,0 +1,16 @@ +'Function' is deprecated - patch to work with older readline API +(e.g., currently in base) or new (e.g., readline 6.3.3 in ports). + +http://lists.gnu.org/archive/html/bug-readline/2014-03/msg00002.html + +--- modules/readline/seed-readline.c.orig 2010-08-30 15:37:39.000000000 -0600 ++++ modules/readline/seed-readline.c 2014-04-15 13:00:13.000000000 -0600 +@@ -77,7 +77,7 @@ + key = seed_value_to_string(ctx, arguments[0], exception); + c = seed_make_rl_closure((SeedObject) arguments[1]); + +- rl_bind_key(*key, (Function *) c); ++ rl_bind_key(*key, (rl_command_func_t *) c); + + g_free(key); + >Release-Note: >Audit-Trail: >Unformatted: