From owner-svn-src-all@FreeBSD.ORG Thu Dec 26 01:51:16 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 34A0D3C6; Thu, 26 Dec 2013 01:51:16 +0000 (UTC) Received: from mail-qe0-x234.google.com (mail-qe0-x234.google.com [IPv6:2607:f8b0:400d:c02::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B385414A7; Thu, 26 Dec 2013 01:51:15 +0000 (UTC) Received: by mail-qe0-f52.google.com with SMTP id ne12so7669680qeb.11 for ; Wed, 25 Dec 2013 17:51:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=bldE/JiDiBwjh05/qG/kMkXmMQ5PfekuYQeCc+cJvv8=; b=ipXIxuinxRFhTNOlJ0V1lhi066sMhpmucGdIHGNFNs2y7IaCXXDYTsxCuEVi7XX+HX gJCtkldRGecw7+v1LiLDqcZ02d72WhxLjzW9M05UgB9lDmwKPfe7DTUa8njZR7YpTu6r lox8s8JUlVCSHWyJYHvGVifO+q4/KjQXqy/XQlk7tI/Ws7FJvnEQoixbuhYMm9ETq6aE 0W+CSrKG1th76gaQZPBTQGEqFb7JTYfyv5nI53oPmVTqlQnPkLo5xtpaQsMLEjainiZm dUaPHH/5TXHvptLe2YL7TzZwASMGJsbSPuY0kdPeRQUHzMPa7XDNfFrhmRjAdDWuX1wd bb9Q== MIME-Version: 1.0 X-Received: by 10.49.34.207 with SMTP id b15mr67581708qej.49.1388022674840; Wed, 25 Dec 2013 17:51:14 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.224.53.200 with HTTP; Wed, 25 Dec 2013 17:51:14 -0800 (PST) In-Reply-To: <201312252245.rBPMjX5J046556@svn.freebsd.org> References: <201312252245.rBPMjX5J046556@svn.freebsd.org> Date: Wed, 25 Dec 2013 17:51:14 -0800 X-Google-Sender-Auth: 6CvOiXzgvDdvp1icsriHpW8HbrQ Message-ID: Subject: Re: svn commit: r259896 - head/sys/dev/cxgb/common From: Adrian Chadd To: Dimitry Andric Content-Type: text/plain; charset=ISO-8859-1 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Dec 2013 01:51:16 -0000 Hi Dim, I'd prefer you didn't remove unused code in drivers like this. If you must, #if 0 them out. Future people hacking on the driver may find it nice to have as much code in there which talks to the hardware. It may not be currently called, but it's at least there. Thanks, -adrian On 25 December 2013 14:45, Dimitry Andric wrote: > Author: dim > Date: Wed Dec 25 22:45:33 2013 > New Revision: 259896 > URL: http://svnweb.freebsd.org/changeset/base/259896 > > Log: > In sys/dev/cxgb/common/cxgb_mc5.c, remove static function > dbgi_wr_addr3(), which is unused since r167514. > > MFC after: 3 days > > Modified: > head/sys/dev/cxgb/common/cxgb_mc5.c > > Modified: head/sys/dev/cxgb/common/cxgb_mc5.c > ============================================================================== > --- head/sys/dev/cxgb/common/cxgb_mc5.c Wed Dec 25 22:36:27 2013 (r259895) > +++ head/sys/dev/cxgb/common/cxgb_mc5.c Wed Dec 25 22:45:33 2013 (r259896) > @@ -98,13 +98,6 @@ static int mc5_cmd_write(adapter_t *adap > F_DBGIRSPVALID, 1, MAX_WRITE_ATTEMPTS, 1); > } > > -static inline void dbgi_wr_addr3(adapter_t *adapter, u32 v1, u32 v2, u32 v3) > -{ > - t3_write_reg(adapter, A_MC5_DB_DBGI_REQ_ADDR0, v1); > - t3_write_reg(adapter, A_MC5_DB_DBGI_REQ_ADDR1, v2); > - t3_write_reg(adapter, A_MC5_DB_DBGI_REQ_ADDR2, v3); > -} > - > static inline void dbgi_wr_data3(adapter_t *adapter, u32 v1, u32 v2, u32 v3) > { > t3_write_reg(adapter, A_MC5_DB_DBGI_REQ_DATA0, v1);