From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Mar 1 14:00:01 2014 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E01036DD for ; Sat, 1 Mar 2014 14:00:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B471217E7 for ; Sat, 1 Mar 2014 14:00:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s21E00ww018514 for ; Sat, 1 Mar 2014 14:00:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s21E00TS018513; Sat, 1 Mar 2014 14:00:00 GMT (envelope-from gnats) Resent-Date: Sat, 1 Mar 2014 14:00:00 GMT Resent-Message-Id: <201403011400.s21E00TS018513@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Christoph Moench-Tegeder Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 47B5B389 for ; Sat, 1 Mar 2014 13:50:54 +0000 (UTC) Received: from smtp.burggraben.net (base.exwg.net [IPv6:2a01:4f8:140:50a2::2]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 0567C1797 for ; Sat, 1 Mar 2014 13:50:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp.burggraben.net (Postfix) with ESMTP id 055686003CD for ; Sat, 1 Mar 2014 14:50:52 +0100 (CET) Received: from smtp.burggraben.net ([127.0.0.1]) by localhost (ns.burggraben.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ya6BeNvIQLrd for ; Sat, 1 Mar 2014 14:50:51 +0100 (CET) Received: from elch.exwg.net (elch.exwg.net [IPv6:2001:470:7b43:1:6a05:caff:fe01:aae9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "elch.exwg.net", Issuer "Christoph Moench-Tegeder" (verified OK)) by smtp.burggraben.net (Postfix) with ESMTPS for ; Sat, 1 Mar 2014 14:50:51 +0100 (CET) Received: by elch.exwg.net (Postfix, from userid 1000) id 3B03F301A8; Sat, 1 Mar 2014 14:50:50 +0100 (CET) Message-Id: <20140301135050.3B03F301A8@elch.exwg.net> Date: Sat, 1 Mar 2014 14:50:50 +0100 (CET) From: Christoph Moench-Tegeder To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.114 Subject: ports/187178: devel/readline : fix PKGNAME X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: Christoph Moench-Tegeder List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Mar 2014 14:00:01 -0000 >Number: 187178 >Category: ports >Synopsis: devel/readline : fix PKGNAME >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Mar 01 14:00:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Christoph Moench-Tegeder >Release: FreeBSD 10.0-RELEASE amd64 >Organization: >Environment: System: FreeBSD elch.exwg.net 10.0-RELEASE FreeBSD 10.0-RELEASE #2 r260689: Wed Jan 15 18:32:44 CET 2014 cmt@elch.exwg.net:/usr/obj/usr/src/sys/ELCH amd64 devel/readline readline-6.3. >Description: When there are no PATCHES to readline, the PATCHLEVEL variable is empty ("") which results in a PKGNAME of "readline-6.3." (note trailing dot). >How-To-Repeat: cmt@disconnector:readline$ make -V PKGNAME readline-6.3. >Fix: Append PATCHLEVEL only when there are patches (that's what the enclosed patch does). Alternatively, force PATCHLEVEL to 0 in case there are no patches. Note for patch: PORTREVISION is not bumped, but I'm not sure how the current port version compares on future updates. Index: Makefile =================================================================== --- Makefile (revision 346619) +++ Makefile (working copy) @@ -2,7 +2,7 @@ # $FreeBSD$ PORTNAME= readline -PORTVERSION= 6.3.${PATCHLEVEL} +PORTVERSION= 6.3${"${PATCHLEVEL}"!=""?".${PATCHLEVEL}":} CATEGORIES= devel MASTER_SITES= GNU \ ftp://ftp.cwru.edu/pub/bash/ Regards, Christoph >Release-Note: >Audit-Trail: >Unformatted: