From owner-svn-src-all@FreeBSD.ORG Mon Sep 6 11:18:55 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7F8C91065696; Mon, 6 Sep 2010 11:18:55 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id 273EA8FC1F; Mon, 6 Sep 2010 11:18:54 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 9867B45CA0; Mon, 6 Sep 2010 13:18:53 +0200 (CEST) Received: from localhost (pdawidek.whl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id E522245C98; Mon, 6 Sep 2010 13:18:48 +0200 (CEST) Date: Mon, 6 Sep 2010 13:18:39 +0200 From: Pawel Jakub Dawidek To: Brian Somers Message-ID: <20100906111839.GB1851@garage.freebsd.pl> References: <201009060415.o864Fntq011178@svn.freebsd.org> <20100906064142.GF1900@garage.freebsd.pl> <20100906011318.3d5c0bb6@dev.lan.Awfulhak.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="JgQwtEuHJzHdouWu" Content-Disposition: inline In-Reply-To: <20100906011318.3d5c0bb6@dev.lan.Awfulhak.org> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT amd64 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=4.5 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r212247 - head/sbin/fdisk X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Sep 2010 11:18:55 -0000 --JgQwtEuHJzHdouWu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 06, 2010 at 01:13:18AM -0700, Brian Somers wrote: > On Mon, 6 Sep 2010 08:41:42 +0200 Pawel Jakub Dawidek w= rote: > > Your assumption that .eli can only be present at the end of provider na= me > > is incorrect. It can be eg. /dev/ad0s1a.eli.journal. > >=20 > > Another problem is that in memmove you cut the first 4 characters, not > > the last 4 characters. > >=20 > > I'm not sure, but can't you simply extend regular expression to: > >=20 > > "^(/dev/[a-z/]+[0-9]+)([sp][0-9]+)?[a-h]?(\.eli)?$" >=20 > You've lost me here. I remove .eli from the device name specifically so = that we > handle it being *anywhere* in the string. Your suggestion only handles i= t being > at the end of the string. >=20 > The memmove doesn't cut the first four characters, it cuts the ".eli" str= ing.... > doesn't it? Yes, sorry for the noice, my reading of the code was incorrect. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --JgQwtEuHJzHdouWu Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkyEzg4ACgkQForvXbEpPzQHHQCfZpO7tjgzY4JlOe6WXazO5CzZ /zYAnjoqf+i5vk9+fQa+9aDGymlNmhIg =6lkV -----END PGP SIGNATURE----- --JgQwtEuHJzHdouWu--