From owner-freebsd-current@FreeBSD.ORG  Thu May 21 11:15:01 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 405271065673;
	Thu, 21 May 2009 11:15:01 +0000 (UTC) (envelope-from dfr@rabson.org)
Received: from itchy.rabson.org (router.rabson.org [80.177.232.241])
	by mx1.freebsd.org (Postfix) with ESMTP id EDB548FC12;
	Thu, 21 May 2009 11:15:00 +0000 (UTC) (envelope-from dfr@rabson.org)
Received: by itchy.rabson.org (Postfix, from userid 80)
	id A5CF25DBA; Thu, 21 May 2009 11:50:38 +0100 (BST)
To: Robert Watson <rwatson@FreeBSD.org>
MIME-Version: 1.0
Date: Thu, 21 May 2009 11:50:38 +0100
From: Doug Rabson <dfr@rabson.org>
In-Reply-To: <alpine.BSF.2.00.0905211135300.25537@fledge.watson.org>
References: <4A1460A3.2010202@freebsd.org>
	<alpine.BSF.2.00.0905202102100.25537@fledge.watson.org>
	<alpine.BSF.2.00.0905211135300.25537@fledge.watson.org>
Message-ID: <a31e4950277c2c6049da0e29cdf71992@mail.rabson.org>
X-Sender: dfr@rabson.org
User-Agent: RoundCube Webmail/0.2.1
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="UTF-8"
Cc: rmacklem@uoguelph.ca, Andre Oppermann <andre@freebsd.org>,
	freebsd-current@freebsd.org
Subject: Re: Socket related code duplication in NFS
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 21 May 2009 11:15:01 -0000


On Thu, 21 May 2009 11:36:49 +0100 (BST), Robert Watson
<rwatson@FreeBSD.org> wrote:
> On Wed, 20 May 2009, Robert Watson wrote:
> 
>> On Wed, 20 May 2009, Andre Oppermann wrote:
>>
>>> While working on an optimized soreceive_stream() function [1] and
>>> checking
>>> the code how it is used I've come across quite a bit of code
duplication
>>> in
>>> the various NFS directories.
>>> 
>>> Socket (read) operations are handled multiple times in a very similar 
>>> manner in these places:
>>
>> My recommendation would be to do this analysis against the new NFS
client
>>
>> and server found in sys/{kgssapi,nlm,fs/{nfs,nfsclient,nfsserver}},
which
>> is
>> the NFSv234 implementation.  Note in particular that in the new world
>> order
>> there's a centralize RPC implementation.
>>
>> The code you're looking at is a blend of the old NFSv23 client/server 
>> (nfsclient/nfsserver) and the old NFSv4 client (rpc/nfs4client), all if 
>> which are on a gradual de-orbit burn.
> 
> After re-reading this e-mail, I realize that I'd mislabeled src/sys/rpc
as 
> being only used by the old code -- this is in fact not the case, it's
also 
> used by the new code.

Everything in src/sys/rpc except rpcclient.[ch] is part of the new RPC
transport. The files rpcclient.c and rpcclient.h are part of the old broken
NFSv4 client which is scheduled for removal.

There is older RPC transport code in src/sys/nfsclient and
src/sys/nfsserver which is currently used if the user uses the
NFS_LEGACYRPC option. This too should be removed before 8.0 ships.