From owner-svn-src-all@FreeBSD.ORG Thu Dec 26 11:13:31 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CBF6CE4D; Thu, 26 Dec 2013 11:13:31 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8327516C0; Thu, 26 Dec 2013 11:13:31 +0000 (UTC) Received: from coleburn.home.andric.com (coleburn.home.andric.com [192.168.0.15]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 226E75C43; Thu, 26 Dec 2013 12:13:28 +0100 (CET) Content-Type: multipart/signed; boundary="Apple-Mail=_637353EF-78EA-4887-B074-A0582A619A1E"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: svn commit: r259896 - head/sys/dev/cxgb/common From: Dimitry Andric In-Reply-To: Date: Thu, 26 Dec 2013 12:13:17 +0100 Message-Id: <76C5CECF-1A27-4245-B5D1-335C46B253E7@FreeBSD.org> References: <201312252245.rBPMjX5J046556@svn.freebsd.org> To: Adrian Chadd X-Mailer: Apple Mail (2.1827) Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Dec 2013 11:13:31 -0000 --Apple-Mail=_637353EF-78EA-4887-B074-A0582A619A1E Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=iso-8859-1 On 26 Dec 2013, at 02:51, Adrian Chadd wrote: > I'd prefer you didn't remove unused code in drivers like this. If you > must, #if 0 them out. I don't mind either way, but some other people are very much opposed to littering code with #if 0'd sections. So, how do to determine what is right in each situation? :-) > Future people hacking on the driver may find it nice to have as much > code in there which talks to the hardware. It may not be currently > called, but it's at least there. In this particular case, the code has never been used, even when the file was originally committed, so I would say the chances of it ever being used again are near zero. (And even after deletion, the old versions are available in our repository.) For more "active" drivers, I will certainly just use #if, or simply turn off the -Wunused-function warning. And hope the code gets used eventually. :-) -Dimitry --Apple-Mail=_637353EF-78EA-4887-B074-A0582A619A1E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iEYEARECAAYFAlK8D1UACgkQsF6jCi4glqM0HwCeNoNZZ832zpI7e6O/LZCC65ML 97QAoIfvOAmGieRcxo8K2ZMdvG/6n6gQ =bgxR -----END PGP SIGNATURE----- --Apple-Mail=_637353EF-78EA-4887-B074-A0582A619A1E--