From owner-freebsd-current@FreeBSD.ORG  Fri Aug  6 22:33:22 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E291E16A4CE
	for <current@freebsd.org>; Fri,  6 Aug 2004 22:33:21 +0000 (GMT)
Received: from spider.deepcore.dk
	(cpe.atm2-0-53484.0x50a6c9a6.abnxx9.customer.tele.dk [80.166.201.166])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0CC4743D1F
	for <current@freebsd.org>; Fri,  6 Aug 2004 22:33:21 +0000 (GMT)
	(envelope-from sos@DeepCore.dk)
Received: from [194.192.25.143] (laptop.deepcore.dk [194.192.25.143])
	by spider.deepcore.dk (8.12.11/8.12.10) with ESMTP id i76MXDbc007697;
	Sat, 7 Aug 2004 00:33:18 +0200 (CEST)
	(envelope-from sos@DeepCore.dk)
Message-ID: <41140722.10807@DeepCore.dk>
Date: Sat, 07 Aug 2004 00:33:06 +0200
From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@DeepCore.dk>
User-Agent: Mozilla Thunderbird 0.7.2 (X11/20040802)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Nate Lawson <nate@root.org>
References: <4113EB2A.7060401@root.org>
In-Reply-To: <4113EB2A.7060401@root.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-mail-scanned: by DeepCore Virus & Spam killer v1.4
cc: Ceri Davies <ceri@submonkey.net>
cc: current@freebsd.org
cc: Radek Kozlowski <radek@raadradd.com>
Subject: Re: Panic on boot with today's CURRENT, ata related
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Aug 2004 22:33:22 -0000

Nate Lawson wrote:
> I took a quick look at this ATA panic.  The exact same one occurs for 
> Ceri.  A quick dissassemble shows that the testb is the check for the 
> DMA flag at the very end of ata_generic_transaction().  The bug appears 
> to be that this may be a PIO request (since the DMA check is outside the 
> switch() statement).  The fix is to make sure it's a DMA request before 
> dereferencing an element of the DMA struct.  Try the attached patch.

No, the fix is to make sure there is a valid ch->dma pointer, the below 
is the correct fix.

--- ata-lowlevel.c      5 Aug 2004 21:13:41 -0000       1.41
+++ ata-lowlevel.c      6 Aug 2004 22:31:16 -0000
@@ -295,7 +295,7 @@
      }

      /* request finish here */
-    if (ch->dma->flags & ATA_DMA_LOADED)
+    if (ch->dma && ch->dma->flags & ATA_DMA_LOADED)
         ch->dma->unload(ch);
      return ATA_OP_FINISHED;
  }