From owner-cvs-src@FreeBSD.ORG Mon May 23 16:04:25 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 350F316A41C; Mon, 23 May 2005 16:04:25 +0000 (GMT) (envelope-from green@green.homeunix.org) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.3/8.13.1) with ESMTP id j4NG4ORt035923; Mon, 23 May 2005 12:04:24 -0400 (EDT) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.3/8.13.1/Submit) id j4NG4Ok0035922; Mon, 23 May 2005 12:04:24 -0400 (EDT) (envelope-from green) Date: Mon, 23 May 2005 12:04:24 -0400 From: Brian Fundakowski Feldman To: "David O'Brien" Message-ID: <20050523160424.GK1201@green.homeunix.org> References: <200505181330.j4IDU8FV035625@repoman.freebsd.org> <20050523073344.GA65484@dragon.NUXI.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050523073344.GA65484@dragon.NUXI.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Giorgos Keramidas , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/top commands.c machine.h top.c src/usr.bin/top machine.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 May 2005 16:04:25 -0000 On Mon, May 23, 2005 at 12:33:44AM -0700, David O'Brien wrote: > On Wed, May 18, 2005 at 01:30:08PM +0000, Giorgos Keramidas wrote: > > keramida 2005-05-18 13:30:08 UTC > > > > FreeBSD src repository (doc committer) > > > > Modified files: > > contrib/top commands.c machine.h top.c > > usr.bin/top machine.c > > Log: > > Merge the CPU and WCPU columns in a single %6.2f column, add a new 'C' > > command that toggles between the two and update the ORDER_PCTCPU() > > macro to sort correctly by the visible "cpu" value. > > Having both CPU and WCPU are a lot more useful than showing the number of > threads. Out of the top 70 processes I'm running right now, only _1_ is > multi-threaded. > > How about backing all this out and making your toggle be between #threads > and something else -- with the something else being the default thing > shown. > > I still don't know what was wrong with the 'H' display of top(1) which > was all about threading. Could you explain what WCPU/CPU are supposed to differentiate? In years of using FreeBSD I don't think I've seen them ever be different, so I'm always left wondering why there's what appears to be wasted screen real-estate. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\