From owner-cvs-all Fri May 31 6: 6:41 2002 Delivered-To: cvs-all@freebsd.org Received: from mail.speakeasy.net (mail12.speakeasy.net [216.254.0.212]) by hub.freebsd.org (Postfix) with ESMTP id D6AB737B407 for ; Fri, 31 May 2002 06:06:13 -0700 (PDT) Received: (qmail 7581 invoked from network); 31 May 2002 13:06:13 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail12.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 31 May 2002 13:06:13 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g4VD6VF36638; Fri, 31 May 2002 09:06:31 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020530225508.GB29853@hades.hell.gr> Date: Fri, 31 May 2002 09:05:53 -0400 (EDT) From: John Baldwin To: Giorgos Keramidas Subject: Re: cvs commit: src/contrib/gcc/config/i386 i386.h Cc: Alfred Perlstein , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, "David O'Brien" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 30-May-2002 Giorgos Keramidas wrote: > On 2002-05-30 11:00 -0400, John Baldwin wrote: >> On 30-May-2002 David O'Brien wrote: >> > I believe a commit message should tell the why, not the way, the diff >> > gives that. >> >> You can always follow up with an e-mail reply to explain what the >> practical implications are, something like "This turns off the i386 #define, >> you should only be using __i386__." or something for us ignorant masses >> who don't know what the log message means. :) I think that is all Alfred >> is asking for here. > > But then, if something is worth mentioning, why not keep in where our > history is going... in the logs? Not everything worth mentioning is worth mentioning in the logs. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message