From owner-freebsd-hackers Wed Oct 30 11:42:35 1996 Return-Path: owner-hackers Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA24395 for hackers-outgoing; Wed, 30 Oct 1996 11:42:35 -0800 (PST) Received: from mailer.syr.edu (mailer.syr.edu [128.230.20.20]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id LAA24384 for ; Wed, 30 Oct 1996 11:42:33 -0800 (PST) Received: from rodan.syr.edu by mailer.syr.edu (LSMTP for Windows NT v1.0a) with SMTP id 7E43A5E0 ; Wed, 30 Oct 1996 14:41:53 -0500 Received: from localhost (cmsedore@localhost) by rodan.syr.edu (8.7.6/8.7.3) with SMTP id OAA08368 for ; Wed, 30 Oct 1996 14:41:29 -0500 (EST) X-Authentication-Warning: rodan.syr.edu: cmsedore owned process doing -bs Date: Wed, 30 Oct 1996 14:41:28 -0500 (EST) From: Christopher Sedore X-Sender: cmsedore@rodan.syr.edu To: FreeBSD hackers Subject: Re: Verbose babble in if_fddisubr.c In-Reply-To: <199610301638.RAA06231@ida.interface-business.de> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-hackers@freebsd.org X-Loop: FreeBSD.org Precedence: bulk > > i've just got a call by a customer who's using a DEC DEFPA FDDI card > now. She told me that everything works fine (once i've pointed her to > the `pseudo-device fddi') but has been a little scared by some verbose > babble caused by the driver. > > After digging around and looking up the error messages, it looks to me > that they've got all kinds of weird frames and packets on their wire, > so the following two printf's hit often enough: > > (sys/net/if_fddisubr.c) > > default: > printf("fddi_input: unknown protocol 0x%x\n", fddi_type); > > .... > default: > printf("fddi_input: unknown dsap 0x%x\n", l->llc_dsap); > ifp->if_noproto++; > > I think both printf's are merely nice debugging aids to see all the > garbage that flies along your wire :), but nothing to be dropped onto > a regular user. I therefore suggest hiding them inside either some > #ifdef, or at least behind `bootverbose'. This is a good idea. I have IPX on my FDDI wire, and this gets annoying in a hurry. Commenting these out is step number 4 in preparing a machine for use around here. How about #ifdef FDDI_VERBOSE or FDDI_DEBUG? -Chris