From owner-svn-src-all@FreeBSD.ORG Mon Mar 15 02:07:27 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ED3FD1065670; Mon, 15 Mar 2010 02:07:27 +0000 (UTC) (envelope-from a_best01@uni-muenster.de) Received: from zivm-relay3.uni-muenster.de (ZIVM-RELAY3.UNI-MUENSTER.DE [128.176.192.19]) by mx1.freebsd.org (Postfix) with ESMTP id 1CFD18FC15; Mon, 15 Mar 2010 02:07:26 +0000 (UTC) X-IronPort-AV: E=Sophos;i="4.49,640,1262559600"; d="scan'208";a="28406404" Received: from zivmaildisp1.uni-muenster.de (HELO ZIVMAILUSER03.UNI-MUENSTER.DE) ([128.176.188.85]) by zivm-relay3.uni-muenster.de with ESMTP; 15 Mar 2010 03:07:25 +0100 Received: by ZIVMAILUSER03.UNI-MUENSTER.DE (Postfix, from userid 149459) id 4908E1B0750; Mon, 15 Mar 2010 03:07:25 +0100 (CET) Date: Mon, 15 Mar 2010 03:07:24 +0100 (CET) From: Alexander Best Sender: Organization: Westfaelische Wilhelms-Universitaet Muenster To: John Baldwin Message-ID: In-Reply-To: <201003111311.52606.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r205013 - in head/sys: amd64/amd64 i386/i386 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Mar 2010 02:07:28 -0000 John Baldwin schrieb am 2010-03-11: > On Thursday 11 March 2010 12:01:28 pm Alexander Best wrote: > > thanks for the commit. :) > > a few thoughts: > > 1) why does stepping remain to be printed in dec while family and > > model are in > > hex? is this the way amd/intel cpu docs refer to > > stepping/model/family? > I just left it the way it was. > > 2) the hex value for "Id" and "(AMD) Features(2)" gets printed with > > an "0x" > > prepended to indicate it's in hex. maybe this should also be the > > case here. > Because on a typical Intel system you overflow 80 cols if you do > that. :( > Otherwise I would have. We could maybe add an 'h' suffix as that is > what > the manuals and it would only add 2 chars rather than 4. ah i see. not an easy decision. i wouldn't use the 'h' suffix, because there should be only one way of relating to a hex value and i believe the overall convention in freebsd is '0x'.so better keep it the way it is. maybe using %X instead of %x in the printfs makes the output look a bit nicer, but that's just eyecandy. ;) cheers. alex