From owner-freebsd-java@FreeBSD.ORG Fri Oct 21 07:00:43 2005 Return-Path: X-Original-To: freebsd-java@freebsd.org Delivered-To: freebsd-java@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DFE4416A41F for ; Fri, 21 Oct 2005 07:00:43 +0000 (GMT) (envelope-from tomasv@megalogika.lt) Received: from megalogika.stp.lt (megalogika.stp.lt [193.219.52.197]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6375C43D45 for ; Fri, 21 Oct 2005 07:00:43 +0000 (GMT) (envelope-from tomasv@megalogika.lt) Received: from pilvas.lan (pilvas.lan [192.169.1.78]) by megalogika.stp.lt (Postfix) with ESMTP id 907B1428; Fri, 21 Oct 2005 10:00:13 +0300 (EEST) Received: by pilvas.lan (Postfix, from userid 1001) id 5D8C94358; Fri, 21 Oct 2005 10:00:12 +0300 (EEST) Date: Fri, 21 Oct 2005 10:00:12 +0300 From: Tomas Verbaitis To: Herve Quiroz Message-ID: <20051021070012.GA6786@megalogika.lt> References: <20051020175328.GA7205@megalogika.lt> <20051020221548.GA3979@arabica.esil.univ-mrs.fr> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zhXaljGHf11kAtnf" Content-Disposition: inline In-Reply-To: <20051020221548.GA3979@arabica.esil.univ-mrs.fr> X-URL: http://blog.hardcore.lt/ve/ X-PGP-Key: http://hardcore.lt/ve/pubkey.txt X-PGP-Key-Fingerprint: E8FB 7C13 99D9 ABDE 0494 B9F6 4D9C F010 881D 3A26 X-nic-hdl: TV13-LT User-Agent: Mutt/1.5.9i Cc: freebsd-java@freebsd.org Subject: Re: Tomcat 5.5 startup and shutdown.. again X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: tomasv@megalogika.lt List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2005 07:00:44 -0000 --zhXaljGHf11kAtnf Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 21, 2005 at 12:15:48AM +0200, Herve Quiroz wrote: > Anyway, there seem to be a problem with your patch (although I have not > tested it yet). >=20 > > --- tomcat.sh.in.orig Wed Sep 14 15:30:23 2005 > > +++ tomcat.sh.in Thu Oct 20 20:18:32 2005 > > -procname=3D"java" > > +procname=3D"%%JAVA_HOME%%/bin/java" > [...] > > --- Makefile.orig Thu Sep 29 18:08:23 2005 > > +++ Makefile Thu Oct 20 20:35:40 2005 > > @@ -64,7 +64,8 @@ > > + JAVA_HOME=3D${JAVA_HOME} > Here you define ${procname} to be hardcoded from a JAVA_HOME value in > the port. This JAVA_HOME is set at install time but the rcNG script > allows to override JAVA_HOME at run-time: >=20 > jakarta_tomcat%%TOMCAT_VERSION%%_java_home =20 Defining ${procname} to $JAVA_HOME_AT_INSTALL_TIME/bin/java is needed so that rcNG script finds Tomcat instance launched by tomcat55ctl. Therefore it suffers from the same problem as daemonctl.c where %%JAVA_HOME%% is also set at port install time. > What will happen if the JAVA_HOME from port install stage and the one > set in rc.conf are different? In this case we get the initial situation again -- rcNG script deals with one instance of tomcat, tomcat55ctl with another.=20 I still think my proposed change still should be applied as it at least gets the default situation right, when both tomcat55ctl and rcNG script refer to the same JVM. The "administrative" approach to this problem would be only to put a warning near the place where jakarta_tomcat%%TOMCAT_VERSION%%_java_home is defined. "Technically" i aggree that it's better to get rid of tomcat55ctl as a program, no matter how convenient and usual it was. --=20 Tomas "Verbaitis" Verbaitis ** http://megalogika.lt * =C5=A1ita gudri be=C5=BEd=C5=BEion=C4=97 moka dirbti su kompiuteriu * --zhXaljGHf11kAtnf Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDWJH8TZzwEIgdOiYRAjzNAJsFD27a33pfwI0GISv+cUp9IUhoSwCgw7jg mSzEhVnS+wKaYolvmruFCoU= =yUI6 -----END PGP SIGNATURE----- --zhXaljGHf11kAtnf--