From owner-freebsd-security Wed Nov 17 14:42:35 1999 Delivered-To: freebsd-security@freebsd.org Received: from kronos.alcnet.com (kronos.alcnet.com [63.69.28.22]) by hub.freebsd.org (Postfix) with ESMTP id A0C6514A1D for ; Wed, 17 Nov 1999 14:42:29 -0800 (PST) (envelope-from kbyanc@alcnet.com) X-Provider: ALC Communications, Inc. http://www.alcnet.com/ Received: from kbyanc (ws-41.alcnet.com [63.69.28.41]) by kronos.alcnet.com (8.9.3/8.9.3/antispam) with SMTP id RAA15573; Wed, 17 Nov 1999 17:42:23 -0500 (EST) From: "Kelly Yancey" To: "'Warner Losh'" , "'Kelly Yancey'" Cc: Subject: RE: kernel stack contents visible from userland Date: Wed, 17 Nov 1999 17:42:22 -0500 Message-ID: <000801bf314d$03fe3f20$291c453f@kbyanc.alcnet.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook 8.5, Build 4.71.2173.0 In-reply-to: <199911172221.PAA19404@harmony.village.org> Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V4.72.3110.3 Sender: owner-freebsd-security@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org > > These patches look good. I wonder if there might be an easier way to > accomplish this. I don't see anything here that is a security risk, > per se, since most of the stat struct is always filled in before the > copyout. Which fields in stat are not explicitly used? I would have > expected them all to be filled in in all cases. It would likely be > faster to just wonk on st_lspare and st_qspare[2] in cvstat... > > Warner > Those are the culprits: the 2 spare fields. In the case of the application I was developing when I noticed this, alignment padding was also an issue, that's why I chose bzero(). I'de be glad to make a new patch set tonight when I get home, assuming someone doesn't beat me to it :) Kelly -- Kelly Yancey - kbyanc@posi.net - Richmond, VA Director of Technical Services, ALC Communications http://www.alcnet.com/ Maintainer, BSD Driver Database http://www.posi.net/freebsd/drivers/ Coordinator, Team FreeBSD http://www.posi.net/freebsd/Team-FreeBSD/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-security" in the body of the message