From owner-freebsd-bugs@freebsd.org Wed Feb 10 02:53:50 2016 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EAC54AA382B for ; Wed, 10 Feb 2016 02:53:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C186ACDA for ; Wed, 10 Feb 2016 02:53:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u1A2roUJ046385 for ; Wed, 10 Feb 2016 02:53:50 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 207070] gptboot not zeroing memory while reading from boot.config Date: Wed, 10 Feb 2016 02:53:50 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.2-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: david@dcrosstech.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2016 02:53:51 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207070 Bug ID: 207070 Summary: gptboot not zeroing memory while reading from boot.config Product: Base System Version: 10.2-STABLE Hardware: amd64 OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: david@dcrosstech.com CC: freebsd-amd64@FreeBSD.org CC: freebsd-amd64@FreeBSD.org This should effect both i386 and amd64.. but I can only pick one. gptboot does not zero the read buffer around line 162, the result is a nondeterminstic, apparently hardware/bios specific condition where parsing fails on the unterminated boot.config file. Patch is: --- /usr/src/sys/boot/i386/gptboot/gptboot.c 2015-08-12 10:22:09.0000000= 00 -0400 +++ gptboot.c 2016-02-05 21:09:12.000000000 -0500 @@ -159,9 +159,9 @@ return (-1); autoboot =3D 1; - *cmd =3D '\0'; for (;;) { + bzero(cmd, sizeof(cmd)); *kname =3D '\0'; if ((ino =3D lookup(PATH_CONFIG)) || (ino =3D lookup(PATH_DOTCONFIG))) Pretty straighforwaed, eliminate the single null terminationa and replace w= ith a bzero of the entire buffer. single byte termination handled the case whe= re here was no boot.config file, but not the case where there was something re= ad it. --=20 You are receiving this mail because: You are the assignee for the bug.=