From owner-cvs-all Sun Oct 28 17:42: 1 2001 Delivered-To: cvs-all@freebsd.org Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by hub.freebsd.org (Postfix) with ESMTP id 5C39C37B408; Sun, 28 Oct 2001 17:41:46 -0800 (PST) Received: (from dillon@localhost) by apollo.backplane.com (8.11.6/8.9.1) id f9T1fW622368; Sun, 28 Oct 2001 17:41:32 -0800 (PST) (envelope-from dillon) Date: Sun, 28 Oct 2001 17:41:32 -0800 (PST) From: Matthew Dillon Message-Id: <200110290141.f9T1fW622368@apollo.backplane.com> To: "Andrey A. Chernov" Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/lastlogin lastlogin.c References: <200110290040.f9T0e5N27673@freefall.freebsd.org> <20011029035153.A693@nagual.pp.ru> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG : :On Sun, Oct 28, 2001 at 16:40:05 -0800, Matt Dillon wrote: :> dillon 2001/10/28 16:40:05 PST :> :> Modified files: :> usr.sbin/lastlogin lastlogin.c :> Log: :> Fix ctime(&int) due to change to lastlog->ll_time : :I am not sure that you are at the right way. Lots of 3rd party programs :from ports do the same things you try to fix. I understand your intention :to fix time type for protocols, but fixing them for utmp or lastlog files :gives more pain than adds value. What is wrong to let lastlog/utmp stay in :machine-dependend format? : :-- :Andrey A. Chernov sizeof(time_t) does not necessarily equal sizeof(int)... even if were only to adopt the 64 bit platform 64 bit time_t's these programs would break because ll_time is an int. I didn't make the ll_time change, but I'm not against it either. -Matt Matthew Dillon To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message