From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Dec 13 14:40:04 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A88B710656B0 for ; Sun, 13 Dec 2009 14:40:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 7DBEC8FC13 for ; Sun, 13 Dec 2009 14:40:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nBDEe4GM061487 for ; Sun, 13 Dec 2009 14:40:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nBDEe4vF061486; Sun, 13 Dec 2009 14:40:04 GMT (envelope-from gnats) Date: Sun, 13 Dec 2009 14:40:04 GMT Message-Id: <200912131440.nBDEe4vF061486@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Graham Todd Cc: Subject: Re: ports/141188: sysutils/freebsd-snapshot does not report all errors X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Graham Todd List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Dec 2009 14:40:04 -0000 The following reply was made to PR ports/141188; it has been noted by GNATS. From: Graham Todd To: "Ralf S. Engelschall" , bug-followup@FreeBSD.org Cc: Subject: Re: ports/141188: sysutils/freebsd-snapshot does not report all errors Date: Sun, 13 Dec 2009 09:35:27 -0500 Ralf S. Engelschall wrote: >> Edwin Groothuis wrote: >>> Maintainer of sysutils/freebsd-snapshot, >>> >>> Please note that PR ports/141188 has just been submitted. >>> >>> If it contains a patch for an upgrade, an enhancement or a bug fix >>> you agree on, reply to this email stating that you approve the patch >>> and a committer will take care of it. >>> >>> The full text of the PR can be found at: >>> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/141188 > > Attention: the patch has a bug in its last chunk: it checks for $? after > the "time_end=`date '+%s'`" command and this way does not check the > possible failure of "snapshot make -g$when $fs:$time_tag.0" but of the > "date" command. > > I've fixed this bug and have taken over the other changes into the > latest version of my snapshot utilities. Find the new version on > http://people.freebsd.org/~rse/dist/ Thanks! With the latest patch to the port everything has been fixed upstream.