From owner-freebsd-current@FreeBSD.ORG  Sun Mar  6 02:43:57 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2271F16A4CE; Sun,  6 Mar 2005 02:43:57 +0000 (GMT)
Received: from mail.mcneil.com (mcneil.com [24.199.45.54])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E8F7443D1D; Sun,  6 Mar 2005 02:43:56 +0000 (GMT)
	(envelope-from sean@mcneil.com)
Received: from localhost (localhost.mcneil.com [127.0.0.1])
	by mail.mcneil.com (Postfix) with ESMTP id 796FFF26ED;
	Sat,  5 Mar 2005 18:43:54 -0800 (PST)
Received: from mail.mcneil.com ([127.0.0.1])
 by localhost (server.mcneil.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 61648-04; Sat,  5 Mar 2005 18:43:54 -0800 (PST)
Received: from mcneil.com (mcneil.com [24.199.45.54])
	by mail.mcneil.com (Postfix) with ESMTP id CCB26F26E9;
	Sat,  5 Mar 2005 18:43:53 -0800 (PST)
From: Sean McNeil <sean@mcneil.com>
To: Maxime Henrion <mux@FreeBSD.org>
In-Reply-To: <20050306002756.GV31320@elvis.mu.org>
References: <1110060467.23311.5.camel@server.mcneil.com>
	 <20050306002756.GV31320@elvis.mu.org>
Content-Type: text/plain
Date: Sat, 05 Mar 2005 18:43:53 -0800
Message-Id: <1110077033.64671.0.camel@server.mcneil.com>
Mime-Version: 1.0
X-Mailer: Evolution 2.0.4 FreeBSD GNOME Team Port 
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by amavisd-new at mcneil.com
cc: current@freebsd.org
Subject: Re: /usr/src/lib/libc/string/strsignal.c:96
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Mar 2005 02:43:57 -0000

On Sun, 2005-03-06 at 01:27 +0100, Maxime Henrion wrote:
> Sean McNeil wrote:
> > Hi folks,
> > 
> > It looks like strsignal is busted.  All I have to do is hit ctrl-c while
> > running gmake and I get this core:
> > 
> > #0  strsignal (num=2) at /usr/src/lib/libc/string/strsignal.c:96
> >         ebuf = "Interrupt", '\0' <repeats 2038 times>
> >         tmp = "2\000\000\000\000\000\000\000\002\000\000\000\000\000\000
> > \000\000\000\000"
> >         signum = 0
> >         n = 4326031
> >         t = 0x7fffffffd151 ""
> >         p = 0x800d5b82f <Address 0x800d5b82f out of bounds>
> > 
> > This is because n is uninitialized when num > 0 && num < sys_nsig.
> 
> Indeed.  Can you confirm that this patch fixes the problem?
> 
> %%
> --- strsignal.c.orig	Tue Mar  1 20:28:14 2005
> +++ strsignal.c	Sun Mar  6 01:24:18 2005
> @@ -64,7 +64,7 @@
>  #endif
>  
>  	if (num > 0 && num < sys_nsig) {
> -		strlcpy(ebuf,
> +		n = strlcpy(ebuf,
>  #if defined(NLS)
>  			catgets(catd, 2, num, sys_siglist[num]),
>  #else
> %%

Yes, this has the desired affect and no more core dump :)

Thanks,
Sean