From owner-cvs-all@FreeBSD.ORG  Thu Dec 11 22:52:26 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 323CD16A4CE; Thu, 11 Dec 2003 22:52:26 -0800 (PST)
Received: from liberty.onthenet.com.au (liberty.OntheNet.com.au
	[203.22.124.10])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C301043D1F; Thu, 11 Dec 2003 22:52:24 -0800 (PST)
	(envelope-from grehan@freebsd.org)
Received: from freebsd.org (CPE-30-201.dsl.onthenet.net [203.144.30.201])
	hBC6qKZG063606;	Fri, 12 Dec 2003 16:52:21 +1000 (EST)
	(envelope-from grehan@freebsd.org)
Message-ID: <3FD965C7.1000906@freebsd.org>
Date: Fri, 12 Dec 2003 16:52:55 +1000
From: Peter Grehan <grehan@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3.1) Gecko/20030524
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Bruce Evans <bde@zeta.org.au>
References: <200312100917.hBA9H26R081659@repoman.freebsd.org>
	<3FD6F0F2.4955B5B2@freebsd.org> <xzpbrqgn11y.fsf@dwp.des.no>
	<3FD7CD6A.8010909@freebsd.org> <20031211030704.GA53066@dragon.nuxi.com>
	<3FD7FD29.7050803@freebsd.org> <20031211194303.X10479@gamplex.bde.org>
In-Reply-To: <20031211194303.X10479@gamplex.bde.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
cc: obrien@freebsd.org
Subject: Re: cvs commit: src/sys/boot/powerpc/loader conf.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Dec 2003 06:52:26 -0000

> These changes seem to be basically correct and have correct style
> except for not merging the declarations of most of the new "int ch"
> variables with the declarations of the other int variables.

  OK, I'll sweep through and fix that.

> The fix for kg_nice in proc.h is missing.  Only the relatively unimportant
> declaration of ki_nice in user.h is fixed.

  Yep, mis-edited that one out of the diff :-(.

> What bugs does putting negative niceness in the (unsigned) char variable
> kg_nice cause?

  Comparisons to NZERO don't work as expected e.g.

/usr/home/grehan/freebsd/dev/src/bin/ps/print.c: In function `state':
/usr/home/grehan/freebsd/dev/src/bin/ps/print.c:250: warning: comparison 
is always false due to limited range of data type

later,

Peter.