From owner-freebsd-current@FreeBSD.ORG  Mon Apr  6 21:11:30 2015
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 5654C59F;
 Mon,  6 Apr 2015 21:11:30 +0000 (UTC)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
 by mx1.freebsd.org (Postfix) with ESMTP id 1A94B7A0;
 Mon,  6 Apr 2015 21:11:29 +0000 (UTC)
Received: from critter.freebsd.dk (unknown [192.168.60.3])
 by phk.freebsd.dk (Postfix) with ESMTP id 234FF3B8A2;
 Mon,  6 Apr 2015 21:11:22 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
 by critter.freebsd.dk (8.14.9/8.14.9) with ESMTP id t36LBLsm070136;
 Mon, 6 Apr 2015 21:11:21 GMT (envelope-from phk@phk.freebsd.dk)
To: John Baldwin <jhb@freebsd.org>
Subject: Re: Early use of log() does not end up in kernel msg buffer
In-reply-to: <2033248.Eu3RHS8lTG@ralph.baldwin.cx>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
References: <5514CC6D.3020607@badgerio.us>
 <2033248.Eu3RHS8lTG@ralph.baldwin.cx>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <70134.1428354681.1@critter.freebsd.dk>
Date: Mon, 06 Apr 2015 21:11:21 +0000
Message-ID: <70135.1428354681@critter.freebsd.dk>
Cc: Eric Badger <eric@badgerio.us>, freebsd-current@freebsd.org
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Apr 2015 21:11:30 -0000

--------
In message <2033248.Eu3RHS8lTG@ralph.baldwin.cx>, John Baldwin writes:

>I think phk@ broke this back in 70239.  Before that the log() function did
>this:
>
>log()
>{
>
>	/* log to the msg buffer */
>	kvprintf(fmt, msglogchar, ...);
>
>	if (!log_open) {
>		/* log to console */
>		kvprintf(fmt, putchar, ...);
>	}
>}
>
>I think your patch is fine unless phk@ (cc'd) has a reason for not wanting to
>do this.

The reason was systems not running syslog having slow serial consoles.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.