From owner-freebsd-ports@FreeBSD.ORG Sun Jul 13 14:05:20 2014 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 56CB4322; Sun, 13 Jul 2014 14:05:20 +0000 (UTC) Received: from hades.sorbs.net (hades.sorbs.net [67.231.146.201]) by mx1.freebsd.org (Postfix) with ESMTP id 40A9A2973; Sun, 13 Jul 2014 14:05:19 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset=UTF-8 Received: from isux.com (firewall.isux.com [213.165.190.213]) by hades.sorbs.net (Oracle Communications Messaging Server 7.0.5.29.0 64bit (built Jul 9 2013)) with ESMTPSA id <0N8N00H61LYKE500@hades.sorbs.net>; Sun, 13 Jul 2014 07:08:46 -0700 (PDT) Message-id: <53C29217.3070307@sorbs.net> Date: Sun, 13 Jul 2014 16:05:11 +0200 From: Michelle Sullivan User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.24) Gecko/20100301 SeaMonkey/1.1.19 To: Dmitry Sivachenko Subject: Re: Patch (not perfect but half way there) for DBIx::SearchBuilder... [Bug: 191734] References: <53B4C581.5060508@sorbs.net> <53B4F7DE.9090300@FreeBSD.org> <53B67F53.9000903@sorbs.net> <53BBC5B9.60004@sorbs.net> <80A36579-08DC-4617-8180-8A2B142C0931@FreeBSD.org> <53BC067F.5080406@sorbs.net> <53BC5041.6080608@sorbs.net> In-reply-to: Cc: ports@freebsd.org, Matthew Seaman X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Jul 2014 14:05:20 -0000 Dmitry Sivachenko wrote: > On 09 июля 2014 г., at 0:10, Michelle Sullivan wrote: > > >> Michelle Sullivan wrote: >> >>> Dmitry Sivachenko wrote: >>> >>> >>>> Did you file an issue for RT at https://bestpractical.com/rt/issues.html ? >>>> >>>> >>>> >>> I filed a bug on CPAN against DBIx::SearchBuilder >>> >>> Here: >>> >>> https://rt.cpan.org/Public/Bug/Display.html?id=96902 >>> >>> Michelle >>> >>> >>> >> FYI Alex (BP) just replied to the bug and he's accepted it to role into >> the next version of DBIx::Searchbuilder >> >> > > Excellent! > > As a matter of interest, and for future reference on my behalf, I have 2 questions: 1/ when would the new version be deployed to FreeBSD ports? (does it need an update or is it automatic? - there might be a _02 or 1.66 patch soon) 2/ is it possible (in my patch here) to only show the option if particular databases are installed (for example for MySQL users the patch makes little to no difference (except for the lag issues) - however it potentially has a huge difference for Oracle and PostgreSQL users.) Regards, Michelle -- Michelle Sullivan http://www.mhix.org/