From owner-cvs-all Tue Jan 27 01:16:04 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id BAA15569 for cvs-all-outgoing; Tue, 27 Jan 1998 01:16:04 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id BAA15562; Tue, 27 Jan 1998 01:16:01 -0800 (PST) (envelope-from davidg@FreeBSD.org) From: David Greenman Received: (from root@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id BAA21694; Tue, 27 Jan 1998 01:15:15 -0800 (PST) Date: Tue, 27 Jan 1998 01:15:15 -0800 (PST) Message-Id: <199801270915.BAA21694@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/netinet in_pcb.c in_pcb.h ip_divert.c raw_ip.c tcp_input.c tcp_subr.c tcp_usrreq.c tcp_var.h udp_usrreq.c Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk davidg 1998/01/27 01:15:15 PST Modified files: sys/netinet in_pcb.c in_pcb.h ip_divert.c raw_ip.c tcp_input.c tcp_subr.c tcp_usrreq.c tcp_var.h udp_usrreq.c Log: Improved connection establishment performance by doing local port lookups via a hashed port list. In the new scheme, in_pcblookup() goes away and is replaced by a new routine, in_pcblookup_local() for doing the local port check. Note that this implementation is space inefficient in that the PCB struct is now too large to fit into 128 bytes. I might deal with this in the future by using the new zone allocator, but I wanted these changes to be extensively tested in their current form first. Also: 1) Fixed off-by-one errors in the port lookup loops in in_pcbbind(). 2) Got rid of some unneeded rehashing. Adding a new routine, in_pcbinshash() to do the initialial hash insertion. 3) Renamed in_pcblookuphash() to in_pcblookup_hash() for easier readability. 4) Added a new routine, in_pcbremlists() to remove the PCB from the various hash lists. 5) Added/deleted comments where appropriate. 6) Removed unnecessary splnet() locking. In general, the PCB functions should be called at splnet()...there are unfortunately a few exceptions, however. 7) Reorganized a few structs for better cache line behavior. 8) Killed my TCP_ACK_HACK kludge. It may come back in a different form in the future, however. These changes have been tested on wcarchive for more than a month. In tests done here, connection establishment overhead is reduced by more than 50 times, thus getting rid of one of the major networking scalability problems. Still to do: make tcp_fastimo/tcp_slowtimo scale well for systems with a large number of connections. tcp_fastimo is easy; tcp_slowtimo is difficult. WARNING: Anything that knows about inpcb and tcpcb structs will have to be recompiled; at the very least, this includes netstat(1). Revision Changes Path 1.38 +198 -105 src/sys/netinet/in_pcb.c 1.23 +34 -23 src/sys/netinet/in_pcb.h 1.18 +2 -1 src/sys/netinet/ip_divert.c 1.51 +2 -1 src/sys/netinet/raw_ip.c 1.69 +11 -27 src/sys/netinet/tcp_input.c 1.42 +5 -5 src/sys/netinet/tcp_subr.c 1.37 +3 -3 src/sys/netinet/tcp_usrreq.c 1.40 +30 -38 src/sys/netinet/tcp_var.h 1.44 +4 -3 src/sys/netinet/udp_usrreq.c