From owner-freebsd-ports@FreeBSD.ORG Mon Jul 14 13:37:32 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6690CA09 for ; Mon, 14 Jul 2014 13:37:32 +0000 (UTC) Received: from mail-pa0-x230.google.com (mail-pa0-x230.google.com [IPv6:2607:f8b0:400e:c03::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 39F0D2908 for ; Mon, 14 Jul 2014 13:37:32 +0000 (UTC) Received: by mail-pa0-f48.google.com with SMTP id bj1so1959826pad.21 for ; Mon, 14 Jul 2014 06:37:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:reply-to:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=mrOZW1WeLEIfFDqSW4VRxoPc6CP9beTiHsWaKOJrrKw=; b=BNVwANCjyx8tRA9wAjwdfxr6Wi35LVcT62Ohp0BtqrQ/gw28APBeJMP9ZhhYokXcam IKlsLZqE3pu29kRAbnMhR2O4NP67H2zXxcqzLFwOZxEFNDEXeQ6zal+kzX8OQuU64CcB ljGMnY9UaU9IrZ/Dbs6S4+cddTldtjrrjMZqjUe7vFdLbAKP07G91IwGyRpWPW94uiZW 5aeZIy8lTms7eph7znt7Qw92rS3Su9bPyVeAjxj7uVDQPnc7Mox7nojFPOOnEc/Hz4vi ehGVdlA/jwluBVQx7D1aFELvC8TE2senXx9EHZ4u6Rnfz3Vyp42XX3PR70K8xgavxd9t RCLg== X-Received: by 10.68.237.67 with SMTP id va3mr16656971pbc.19.1405345050387; Mon, 14 Jul 2014 06:37:30 -0700 (PDT) Received: from [192.168.1.7] (ppp59-167-128-11.static.internode.on.net. [59.167.128.11]) by mx.google.com with ESMTPSA id iq10sm10911438pbc.14.2014.07.14.06.37.28 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Jul 2014 06:37:29 -0700 (PDT) Sender: Kubilay Kocak Message-ID: <53C3DD16.2040009@FreeBSD.org> Date: Mon, 14 Jul 2014 23:37:26 +1000 From: Kubilay Kocak Reply-To: koobs@FreeBSD.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Carlos Jacobo Puga Medina , freebsd-ports@freebsd.org Subject: Re: Please commit bug 190843 References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jul 2014 13:37:32 -0000 On 14/07/2014 11:23 PM, Carlos Jacobo Puga Medina wrote: > Added patch to update to 0.7.0 > > Build logs: > > https://redports.org/buildarchive/20140714113400-20929/ > > --CJPM > _______________________________________________ > freebsd-ports@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ports > To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org" > Thanks for your submission Carlos :) Our issue tracker is the authoritative source of information for change requests, so always include all information there before posting on the mailing lists. I also note that OPTIONS_DEFAULT is added in your patch but has no value, so you may want to provide a second version of your patch fixing that, including the MAINTAINER update, and posting the URL to your redports build in a comment, noting that its ready to commit. Running portlint (with -AC) flags is also highly recommended (add the output in your comment too, even if its clean) This gives committers confidence++ that your submission is ready to rock -- koobs