From owner-freebsd-ports@FreeBSD.ORG Mon Jul 14 14:36:23 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F2AEC85E; Mon, 14 Jul 2014 14:36:22 +0000 (UTC) Received: from mail-vc0-x233.google.com (mail-vc0-x233.google.com [IPv6:2607:f8b0:400c:c03::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9FE052E4E; Mon, 14 Jul 2014 14:36:22 +0000 (UTC) Received: by mail-vc0-f179.google.com with SMTP id id10so7286537vcb.38 for ; Mon, 14 Jul 2014 07:36:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=PWQmjwA5OpaNEU6ZHC1UKbYk4Ag2R3K5+hzXFDGYzEw=; b=agsK2A4Ua/eOVS1/TA3l566i20j3b4+qpiSoxMHYMMFLbbxnm9Fpuad8AXCanzLbWb 64iFaCm9xjzEBOTsssxEOk94MNrlEwjBgRKEeU/Kl2bZXrxzYJVZwlZR/tv8CwLDA1ot M/nM8jjVHP4sSD/FT5jP06inZjBGAWoPHL8suLj1+zFVA4R8vpp+1iNbiUgLoJDs42l6 SEmLKVOxwW940YScxl7fP6MZT5Ou+HJxX3/CJpKa7BYOO/4/fZajQLJo9gzYgXmTGjP9 1yFcqqEClc36DWz+1JjzTDqdpsLXLr9jf1216QmRtVug2jwZzC8lcGBwzxvqb873UXBT AKgg== MIME-Version: 1.0 X-Received: by 10.220.250.203 with SMTP id mp11mr16552782vcb.2.1405348581600; Mon, 14 Jul 2014 07:36:21 -0700 (PDT) Received: by 10.220.131.202 with HTTP; Mon, 14 Jul 2014 07:36:21 -0700 (PDT) In-Reply-To: <53C3DD16.2040009@FreeBSD.org> References: <53C3DD16.2040009@FreeBSD.org> Date: Mon, 14 Jul 2014 16:36:21 +0200 Message-ID: Subject: Re: Please commit bug 190843 From: Carlos Jacobo Puga Medina To: koobs@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18 Cc: freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jul 2014 14:36:23 -0000 2014-07-14 15:37 GMT+02:00 Kubilay Kocak : > On 14/07/2014 11:23 PM, Carlos Jacobo Puga Medina wrote: > > Added patch to update to 0.7.0 > > > > Build logs: > > > > https://redports.org/buildarchive/20140714113400-20929/ > > > > --CJPM > > _______________________________________________ > > freebsd-ports@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-ports > > To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org" > > > > Thanks for your submission Carlos :) > > Our issue tracker is the authoritative source of information for change > requests, so always include all information there before posting on the > mailing lists. > > I also note that OPTIONS_DEFAULT is added in your patch but has no > value, so you may want to provide a second version of your patch fixing > that, including the MAINTAINER update, and posting the URL to your > redports build in a comment, noting that its ready to commit. > > Fixed. > Running portlint (with -AC) flags is also highly recommended (add the > output in your comment too, even if its clean) > > This gives committers confidence++ that your submission is ready to rock > > Thanks for your useful tips, koobs@ > -- > koobs > > > > Kind regards, --CJPM