From owner-cvs-src@FreeBSD.ORG Mon Aug 16 01:51:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD0D316A4D1 for ; Mon, 16 Aug 2004 01:51:10 +0000 (GMT) Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by mx1.FreeBSD.org (Postfix) with ESMTP id 73F6643D45 for ; Mon, 16 Aug 2004 01:51:10 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: (qmail 25014 invoked from network); 16 Aug 2004 01:51:09 -0000 Received: from gate.funkthat.com (HELO hydrogen.funkthat.com) ([69.17.45.168]) (envelope-sender ) by mail6.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 16 Aug 2004 01:51:09 -0000 Received: from hydrogen.funkthat.com (ojuzmj@localhost.funkthat.com [127.0.0.1])i7G1p8uU095673; Sun, 15 Aug 2004 18:51:09 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.10/8.12.10/Submit) id i7G1p88P095672; Sun, 15 Aug 2004 18:51:08 -0700 (PDT) Date: Sun, 15 Aug 2004 18:51:08 -0700 From: John-Mark Gurney To: Brian Fundakowski Feldman Message-ID: <20040816015108.GQ991@funkthat.com> References: <200408150624.i7F6OhhR074096@repoman.freebsd.org> <20040816014244.GB3026@green.homeunix.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040816014244.GB3026@green.homeunix.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_target.c src/sys/dev/mii mii.c src/sys/fs/fifofs fifo_vnops.c src/sys/gnu/ext2fs ext2_vnops.c src/sys/kern init_main.c kern_conf.c kern_descrip.c kern_event.c kern_exec.c kern_exit.c kern_fork.c kern_sig.c sys_pipe.c tty.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Aug 2004 01:51:10 -0000 Brian Fundakowski Feldman wrote this message on Sun, Aug 15, 2004 at 21:42 -0400: > On Sun, Aug 15, 2004 at 06:24:43AM +0000, John-Mark Gurney wrote: > > Log: > > Add locking to the kqueue subsystem. This also makes the kqueue subsystem > > a more complete subsystem, and removes the knowlege of how things are > > implemented from the drivers. Include locking around filter ops, so a > > module like aio will know when not to be unloaded if there are outstanding > > knotes using it's filter ops. > > > > Currently, it uses the MTX_DUPOK even though it is not always safe to > > aquire duplicate locks. Witness currently doesn't support the ability > > to discover if a dup lock is ok (in some cases). > > Yay, kqueues for 5.3-RELEASE that won't panic/lock up my system!! Do you > think we should make this change now? Yep, looks like we should... > Also, would you mind if I gave it a quick once-over for the bigger style(9) > concerns? No functional changes/code moving, just parentheses and such. sure, I'd like a quick peak at the patch though (if it takes me more than a day, go ahead and commit). -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."