From owner-cvs-all@FreeBSD.ORG Wed Aug 31 11:36:51 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5961016A41F; Wed, 31 Aug 2005 11:36:51 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 17A2143D45; Wed, 31 Aug 2005 11:36:51 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j7VBao3N079997; Wed, 31 Aug 2005 11:36:50 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j7VBaoKD079996; Wed, 31 Aug 2005 11:36:50 GMT (envelope-from yar) Message-Id: <200508311136.j7VBaoKD079996@repoman.freebsd.org> From: Yar Tikhiy Date: Wed, 31 Aug 2005 11:36:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if_vlan.c if_vlan_var.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Aug 2005 11:36:51 -0000 yar 2005-08-31 11:36:50 UTC FreeBSD src repository Modified files: sys/net if_vlan.c if_vlan_var.h Log: Use VLAN_TAG_VALUE() not only to read a dot1q tag value from an m_tag, but also to set it. This reduces complex code duplication and improves its readability. Alas, we shouldn't rename the macro to VLAN_TAG_LVALUE() globally because that would cause pain for kernel module port maintainers and vendors using FreeBSD as their codebase. Added a clarifying comment instead. Discussed with: ru, glebius X-MFC-After: 6.0-RELEASE (MFC is good just to reduce the diff) Revision Changes Path 1.83 +1 -1 src/sys/net/if_vlan.c 1.22 +7 -2 src/sys/net/if_vlan_var.h