From owner-freebsd-net  Fri Jan  5  8:12: 5 2001
From owner-freebsd-net@FreeBSD.ORG  Fri Jan  5 08:12:03 2001
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [18.24.4.193])
	by hub.freebsd.org (Postfix) with ESMTP id A8A2A37B400
	for <freebsd-net@FreeBSD.ORG>; Fri,  5 Jan 2001 08:12:02 -0800 (PST)
Received: (from wollman@localhost)
	by khavrinen.lcs.mit.edu (8.9.3/8.9.3) id LAA70969;
	Fri, 5 Jan 2001 11:11:12 -0500 (EST)
	(envelope-from wollman)
Date: Fri, 5 Jan 2001 11:11:12 -0500 (EST)
From: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
Message-Id: <200101051611.LAA70969@khavrinen.lcs.mit.edu>
To: "Pedro J. Lobo" <pjlobo@euitt.upm.es>
Cc: freebsd-net@FreeBSD.ORG
Subject: Updated fxp VLAN patch for 4.2-RELEASE
In-Reply-To: <Pine.BSF.4.21.0101051139310.495-100000@deneb.euitt.upm.es>
References: <Pine.BSF.4.21.0101051139310.495-100000@deneb.euitt.upm.es>
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

<<On Fri, 5 Jan 2001 11:46:07 +0100 (CET), "Pedro J. Lobo" <pjlobo@euitt.upm.es> said:

> - It doesn't modify if_vlan.c anymore. Instead, it uses ifi_hdrlen to tell
> if_vlan.c that it supports long frames.

This looks good -- but I'm a bit confused by this segment of code:

+ #if NVLAN > 0
+       ifp->if_data.ifi_hdrlen = sizeof(struct ether_vlan_header);
+ #else
+       if (sc->not_82557) {
+               ifp->if_data.ifi_hdrlen = sizeof(struct ether_vlan_header);
+       }
+ #endif

Can you explain the logic here?  (This seems to interfere with the
loadability of this module.)

-GAWollman



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message