From owner-cvs-all@FreeBSD.ORG  Wed Jul 21 23:10:36 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8168E16A4CE; Wed, 21 Jul 2004 23:10:36 +0000 (GMT)
Received: from arginine.spc.org (arginine.spc.org [195.206.69.236])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id A20B343D2F; Wed, 21 Jul 2004 23:10:35 +0000 (GMT)
	(envelope-from bms@spc.org)
Received: from localhost (localhost [127.0.0.1])
	by arginine.spc.org (Postfix) with ESMTP
	id AFC38653AD; Thu, 22 Jul 2004 00:10:33 +0100 (BST)
Received: from arginine.spc.org ([127.0.0.1])
 by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id 44094-02-2; Thu, 22 Jul 2004 00:10:33 +0100 (BST)
Received: from empiric.dek.spc.org (82-147-17-88.dsl.uk.rapidplay.com
	[82.147.17.88])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by arginine.spc.org (Postfix) with ESMTP
	id DEB4F652EC; Thu, 22 Jul 2004 00:10:32 +0100 (BST)
Received: by empiric.dek.spc.org (Postfix, from userid 1001)
	id 7225C615E; Thu, 22 Jul 2004 00:10:31 +0100 (BST)
Date: Thu, 22 Jul 2004 00:10:31 +0100
From: Bruce M Simpson <bms@spc.org>
To: Andre Oppermann <andre@FreeBSD.org>
Message-ID: <20040721231031.GB775@empiric.dek.spc.org>
Mail-Followup-To: Andre Oppermann <andre@FreeBSD.org>,
	src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
References: <200407211955.i6LJtEIl069104@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200407211955.i6LJtEIl069104@repoman.freebsd.org>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/netinet ip_fw2.c src/sbin/ipfw ipfw.8
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Jul 2004 23:10:36 -0000

On Wed, Jul 21, 2004 at 07:55:14PM +0000, Andre Oppermann wrote:
>   Log:
>   Extend versrcreach by checking against the rt_flags for RTF_REJECT and
>   RTF_BLACKHOLE as well.

I looked at this, and it looked good. The only caveat I can think of it this:
it won't DTRT for routes pointing to an instance of disc(4) unless these
flags are also explicitly set for such routes.

Other than that, useful and good.

Regards,
BMS